website-scraper / node-website-scraper / 27983945269

96%

push

github

Replace "should" with "chai" (#609)

* Replace "should" with "chai"

* Fix lint issues and conversion artifacts from should→chai migration

Resolves the 33 blocking qlty (eslint) issues reported on the PR and
corrects a few artifacts left by the automated conversion:

- Restore test/unit/plugins.test.js to empty (a placeholder Array#indexOf
  test was added by mistake)
- Convert tabs/quotes/=== in test/utils/assertions.js to match style
- Fix indentation and stray quotes/spaces across several test files
- Add `mocha` env to .eslintrc.yml so test globals (describe/it) lint cleanly
- Drop redundant duplicate `chai.should()` calls
- Remove no-op `.should.be.a.string` assertions (no such chai assertion)
- Drop dead `()` from `false.should.be.true()` (chai `.true` is a getter)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

357 of 360 branches covered (99.17%)

1471 of 1476 relevant lines covered (99.66%)

92.0 hits per line