thanos / ex_datalog / a5a58bc94a3f97a021af103bf76be2963a025de9-PR-162

93%

main: 93%

Pull #162

github

Summary of fixes
High — Correctness
- F-001 (the real bug): MagicSets.rewrite_rule/5 now uses Enum.map_reduce to give each supplementary rule a distinct ID, and do_transform runs a defensive assert_unique_rule_ids!/1 on the transformed IR. Verified the doubly-recursive case now produces IDs [0,1,2,3] with no provenance-map collapse.
- F-007: Added a doubly-recursive (reach(X,Z) :- reach(X,Y), reach(Y,Z)) regression suite — asserts unique IDs, full provenance map, correct goal subset, and a clean explain: true run.
High — Documentation contradictions (introduced by the branch)
- F-002 / F-013: Rewrote article 06 — the planner is now correctly described as a standalone inspection tool off the eval path; removed the nonexistent eval_plan/2; corrected the "magic sets still runs semi-naive" claim; fixed the "is now.Compiler" typo and all the "engine consumes the plan" statements.
- F-003: Article 07 now documents the :aggregate_result_not_in_head rejection and that non-integer inputs raise ArgumentError.
- F-004: Article 09 now shows the correct /5 and /4 signatures, documents the supplementary demand-propagation rule, and replaces the false "derives only four facts" claim with an accurate disconnected-component explanation.
Medium
- F-005: New tests for result-not-in-head rejection, sum/min/max integer guards raising, and count accepting non-integers.
- F-006: Settled the contract — non-integer aggregate inputs raise (consistent with the integer-only design); documented in materialize/2 and the aggregate moduledoc, with tests pinning it.
Low / Nit
- F-008/F-009/F-010: Corrected stale docstrings (no build-time validation claim; sum raises not filters; updated the Enum.min/max reference).
- F-011: flushlate → flush_late.
- F-012: Zero-field relations now raise a clear DSL.CompileError at compile time instead of silently breaking the whole schema; documented.

363 of 404 new or added lines in 17 files covered. (89.85%)

1408 of 1508 relevant lines covered (93.37%)

541.71 hits per line