• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stacklok / toolhive / 27978488606
67%

Build:
DEFAULT BRANCH: main
Ran 22 Jun 2026 07:36PM UTC
Jobs 1
Files 772
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

22 Jun 2026 07:30PM UTC coverage: 67.084% (-0.009%) from 67.093%
27978488606

push

github

web-flow
Add public Kubernetes-backed dynamic BackendRegistry constructor (#5542)

* Add public Kubernetes-backed BackendRegistry constructor

Implements changes for issue #5541:
- Add registry.NewKubernetesBackendRegistry: bundles DynamicRegistry +
  k8s.BackendWatcher + watcher goroutine behind one call so embedders get
  live K8s backend discovery without importing pkg/vmcp/k8s or
  k8s.io/client-go/rest
- Default to in-cluster rest.Config, overridable via WithRESTConfig option
- Start the registry empty and let the watcher's initial informer sync
  populate it, avoiding the static path's groups/container-runtime deps
- Add example embedder plus an import-graph test enforcing the embedder
  does not directly import the K8s watch substrate or REST package

* Document watcher lifecycle and cross-reference CR test

Address code review feedback:
- MEDIUM: Expand NewKubernetesBackendRegistry doc with the background
  watcher's lifecycle and async-failure contract — caller must cancel
  ctx to release the goroutine; Start failures are logged not returned,
  so readiness is observed via the returned server.Watcher
- MEDIUM: Cross-reference the envtest BackendReconciler integration
  suite that exercises the CR-to-DynamicRegistry add/remove path this
  constructor reuses

* Rename registry package to backendregistry

Addresses stacklok/toolhive#5542 review comments:
- MEDIUM pkg/vmcp/registry/registry.go (3429022196): package name
  collided with the top-level pkg/registry (package registry, 24
  importers) and pkg/vmcp/registry.go (package vmcp). Rename to
  pkg/vmcp/backendregistry (package backendregistry) while there are no
  importers, so dual-importers no longer need an alias.

* Address PR review polish on backendregistry

Addresses stacklok/toolhive#5542 review comments:
- MEDIUM registry.go (3429022190): reword the returned-value doc — it is
  the live registry the watcher mutates, not immutable; embedders treat
  it as read-only
- MEDIUM registry.go (3429... (continued)

30 of 57 new or added lines in 2 files covered. (52.63%)

5 existing lines in 2 files now uncovered.

69799 of 104047 relevant lines covered (67.08%)

65.51 hits per line

Uncovered Changes

Lines Coverage ∆ File
23
0.0
pkg/vmcp/backendregistry/internal/exampleembedder/exampleembedder.go
4
88.24
pkg/vmcp/backendregistry/registry.go

Coverage Regressions

Lines Coverage ∆ File
3
97.37
-0.53% pkg/authz/authorizers/cedar/core.go
2
94.77
-1.31% pkg/vmcp/composer/dag_executor.go
Jobs
ID Job ID Ran Files Coverage
1 27978488606.1 22 Jun 2026 07:36PM UTC 772
67.08
GitHub Action Run
Source Files on build 27978488606
  • Tree
  • List 772
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #27978488606
  • 80d77d78 on github
  • Prev Build on main (#27971383297)
  • Next Build on main (#27980106310)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc