stacklok / toolhive / 27978488606

67%

Build Type

push

github

Committed by web-flow

Commit Message

Add public Kubernetes-backed dynamic BackendRegistry constructor (#5542)

* Add public Kubernetes-backed BackendRegistry constructor

Implements changes for issue #5541:
- Add registry.NewKubernetesBackendRegistry: bundles DynamicRegistry +
  k8s.BackendWatcher + watcher goroutine behind one call so embedders get
  live K8s backend discovery without importing pkg/vmcp/k8s or
  k8s.io/client-go/rest
- Default to in-cluster rest.Config, overridable via WithRESTConfig option
- Start the registry empty and let the watcher's initial informer sync
  populate it, avoiding the static path's groups/container-runtime deps
- Add example embedder plus an import-graph test enforcing the embedder
  does not directly import the K8s watch substrate or REST package

* Document watcher lifecycle and cross-reference CR test

Address code review feedback:
- MEDIUM: Expand NewKubernetesBackendRegistry doc with the background
  watcher's lifecycle and async-failure contract — caller must cancel
  ctx to release the goroutine; Start failures are logged not returned,
  so readiness is observed via the returned server.Watcher
- MEDIUM: Cross-reference the envtest BackendReconciler integration
  suite that exercises the CR-to-DynamicRegistry add/remove path this
  constructor reuses

* Rename registry package to backendregistry

Addresses stacklok/toolhive#5542 review comments:
- MEDIUM pkg/vmcp/registry/registry.go (3429022196): package name
  collided with the top-level pkg/registry (package registry, 24
  importers) and pkg/vmcp/registry.go (package vmcp). Rename to
  pkg/vmcp/backendregistry (package backendregistry) while there are no
  importers, so dual-importers no longer need an alias.

* Address PR review polish on backendregistry

Addresses stacklok/toolhive#5542 review comments:
- MEDIUM registry.go (3429022190): reword the returned-value doc — it is
  the live registry the watcher mutates, not immutable; embedders treat
  it as read-only
- MEDIUM registry.go (3429... (continued)

Coverage Stats

30 of 57 new or added lines in 2 files covered. (52.63%)

5 existing lines in 2 files now uncovered.

69799 of 104047 relevant lines covered (67.08%)

65.51 hits per line