Gallopsled / pwntools / 27970852263

74%

Build Type

push

github

Committed by web-flow

Commit Message

Guide users to libc_start_main_return for __libc_start_main_ret (#2746)

* guide users to libc_start_main_return for __libc_start_main_ret

looking up __libc_start_main_ret on ELF(libc).sym just threw a plain
KeyError/AttributeError even though libcdb shows that symbol, which is
confusing (issue 2563). it's not a real symbol so we can't just add it,
and computing it means disassembling __libc_start_main which we don't
want to do for everyone by default.

so for now the symbols dotdict raises a message pointing at the existing
ELF.libc_start_main_return property when you ask for that key. lazy auto
calc can come later. added a doctest covering both sym['...'] and
sym.__libc_start_main_ret access, tests pass.

* use bare super() in symboldict

peace-maker noted new code can use py3 super(), so drop the
redundant (symboldict, self) args.

* add changelog entry for 2746

---------

Co-authored-by: peace-maker <peacemakerctf@gmail.com>

Coverage Stats

3950 of 6622 branches covered (59.65%)

11 of 12 new or added lines in 1 file covered. (91.67%)

16 existing lines in 5 files now uncovered.

13618 of 18408 relevant lines covered (73.98%)

0.74 hits per line