stacklok / toolhive / 27960684761

67%

Build Type

push

github

Committed by web-flow

Commit Message

Add testutil.NewScheme helper and migrate operator test schemes (#5565)

Add testutil.NewScheme and migrate operator tests

Operator unit tests hand-rolled runtime.NewScheme() + per-type
AddToScheme blocks in ~57 files, plus 11 near-identical package-level
scheme-builder helpers. The same registration set was copy-pasted
hundreds of times, drifting in which types each test bothered to add.

Introduce a single shared helper, testutil.NewScheme(t), that registers
the client-go built-in types plus both operator API versions, with a
variadic for the rare test needing an extra API (e.g. apiextensionsv1).
Migrate every scheme-construction site to it and delete the 11 redundant
builders. Net -520 lines; no behavior change (the built-in superset is a
no-op for fake clients that don't use the extra types).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

12 of 12 new or added lines in 1 file covered. (100.0%)

75 existing lines in 5 files now uncovered.

69590 of 103672 relevant lines covered (67.13%)

64.77 hits per line