aelassas / servy / 27951698108

86%

push

github

fix(core): ServiceDtoImportValidator.cs - import structural/size/empty error messages are hardcoded English while domain-validation errors use localized Strings.Msg_* resources (#3870)
fix(desktop): ServiceCommands.cs (Servy) - wait cursor set before name validation in Start/Stop/Restart but after validation in Install/Uninstall (#3369)
fix(core): IWindowsServiceApi.cs - boolean <returns> docs use three different styles (<c>true</c> vs <see langword> vs prose) across sibling methods (#3776)
fix(core): SecureData.cs - _v2EncryptionKey/_v2HmacKey declared non-nullable byte[] but null-checked in ctor catch and Dispose (finalizer can observe null) (#3773)
fix(desktop): MainViewModel.cs (Manager) - constructor guards are inverted vs annotations: nullable parameters throw, non-nullable helpService/messageBoxService are accepted null (#3321)
fix(manager): ServiceCommands.cs (Manager) - ExportServiceConfigAsync throws on null service and skips the Name check; all sibling commands early-return false (#3292)
fix(core): IProtectedKeyProvider does not extend IDisposable while sibling ISecureData does - consumers cannot trigger the key-zeroing Dispose through the abstraction (#3252)
fix(core): ServiceDto.cs - ShouldSerializeEnableConsoleUI is appended at the end of the ShouldSerialize block instead of declaration order like every sibling (#3187)
fix(cli): ServiceInstallValidator.cs - MapInt/MapEnum build hardcoded English error messages while every other validation failure is localized via Strings.resx (#3178)
fix(core): ServiceDependenciesValidator.Validate(string) vs ServiceDependenciesParser.Parse(string?) - sibling methods disagree on input nullability (Validate null-guards a non-nullable param) (#3641)
test: XmlServiceValidatorTests.cs - assertions mix hardcoded English error strings with Strings.Msg_* resource constants (reword-fragile; sibling of #2935) (#4097)
chore(core): ServiceDto.cs - six properties carry 'Gets or sets' docs copy-pasted from Domain/Ser... (continued)

1926 of 2190 branches covered (87.95%)

Branch coverage included in aggregate %.

20 of 21 new or added lines in 7 files covered. (95.24%)

13081 of 15387 relevant lines covered (85.01%)

92.27 hits per line