GEWIS / sudosos-backend / 27945855236

92%

push

github

feat: ToS version acceptance tracking (#963)

* feat: add TermsOfServiceAcceptance entity and migration

Adds a table recording which TOS version each user accepted and when,
plus a user.tosRequired flag replacing the stored acceptedToS enum.
The migration backfills tosRequired and inserts version 1.0 acceptance
rows for users that had accepted the legacy single-version TOS.

* feat: add derived TOS status logic to TermsOfServiceService

getCurrentVersion (cached highest version), getUserTosStatus,
haveUsersAcceptedCurrent (bulk variant for transaction checks),
and getAcceptances for the audit endpoint.

* feat!: derive TOS status from acceptance records

- user.tosRequired replaces the stored acceptedToS enum; the status is
  computed against the current TOS version
- POST /users/acceptTos requires the version being accepted and rejects
  non-current or already-accepted versions with a 400
- JWT carries a computed top-level acceptedToS field; the restriction
  middleware falls back to the legacy embedded field for old tokens
- UserResponse.acceptedToS is replaced by tosRequired (breaking);
  AuthenticationResponse.acceptedToS is unchanged but now computed
- transaction verification and the userMustExist validator check
  acceptance of the current version

* feat: add GET /users/{id}/tos audit endpoint

Returns the computed TOS status, the current TOS version, and the
full acceptance history of a user.

* test: update seeders and user factory for TOS acceptance records

Seeded users get tosRequired plus an acceptance record of the current
TOS version so they keep transacting in tests.

* test: adapt tests to derived TOS status

- tosRequired replaces acceptedToS in fixtures; token-level acceptedToS
  in restriction middleware tests
- new tests for getCurrentVersion, getUserTosStatus,
  haveUsersAcceptedCurrent, getAcceptances, GET /users/{id}/tos, and
  the versioned accept flow (wrong version, duplicate, re-accept)

* test: fix invoice and base-contr... (continued)

4235 of 4841 branches covered (87.48%)

Branch coverage included in aggregate %.

165 of 177 new or added lines in 20 files covered. (93.22%)

21837 of 23488 relevant lines covered (92.97%)

841.59 hits per line