stacklok / toolhive-studio / 27943384117

71%

push

github

fix(newsletter): stop dismissal re-pop loop and add DB write observability (#2324)

* fix(newsletter): stop dismissal re-pop loop and add DB write observability

The newsletter modal re-pops because the dismissal is never persisted when the
SQLite write fails silently. First step of #2321:

- setNewsletterDismissedAt now reports whether the dismissal was actually
  persisted. The renderer suppresses the modal for the rest of the session only
  when it wasn't — stopping the in-session re-pop loop on a read-only DB or a
  failed write, while leaving the normal (persisted) flow unchanged.
- Instrument DB write failures in Sentry, separating Bucket A (read-only DB:
  on-disk schema newer than the app, captured in the migrator with applied vs
  known schema) from Bucket B (the write threw, captured with the SQLite error
  code). os.name / release are attached automatically. Today these failures are
  invisible — Bucket A doesn't even produce a local log.

Refs #2321

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor(db): use a stable Sentry message for read-only telemetry

Address PR review: the schema versions were interpolated into the
captureMessage string, which Sentry uses for grouping and would fragment
the signal into a separate issue per schema combo. Use a fixed message and
keep the versions in extras.

Refs #2321

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

5206 of 7964 branches covered (65.37%)

13 of 23 new or added lines in 5 files covered. (56.52%)

7692 of 10860 relevant lines covered (70.83%)

115.8 hits per line