KarpelesLab / libwallet / 27926027683

24%

push

github

wltswap/okx: decode Solana tx.data as base58 or base64 by validating structure

OKX's DEX aggregator /swap endpoint returns Solana tx.data base58-encoded,
but okxDecodeSolanaTxData only ran it through base64. Since base58's alphabet
is a subset of base64's, a base64 decode of a base58 payload SUCCEEDS but
yields garbage — whose leading byte was read as a 79-signature count,
surfacing in the field as:

  LibwalletException(500): sign okx solana transaction: signatures truncated:
  declared 79, tx only 708 bytes

Some routes do return genuine base64 (the earlier "illegal base64 at input
1096" case had real -/_ chars, which base58 never contains), so both
encodings occur depending on the route.

Decode under both schemes and return the candidate that parses as a
structurally valid Solana transaction via the new looksLikeSolanaTx
(numSigs >= 1 and sigsEnd < len). base58 decode only succeeds on the base58
alphabet, so genuine base64 payloads never yield a false base58 candidate;
the structural check cleanly distinguishes a correct decode (numSigs=1,
sigsEnd=65 < 708) from its garbage base64 twin (numSigs=79, sigsEnd >> len).

Test now covers base58 alongside all four base64 variants using a
structurally-valid 1.1 KB tx blob.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

30 of 35 new or added lines in 2 files covered. (85.71%)

4520 of 18792 relevant lines covered (24.05%)

100.74 hits per line