sunng87 / handlebars-rust / 27924635617

85%

push

github

fix: inherit @key/@index/@first/@last into partials and #with (#758)

The implicit data variables (@key, @index, @first, @last) set by an
enclosing {{#each}} were not accessible inside a partial (or {{#with}}),
because entering those scopes pushed a fresh BlockContext whose empty
local variables shadowed the enclosing each's. This diverged from
Handlebars.js, where data variables are inherited across these
boundaries.

Resolve by inheriting the parent block's local variables into the new
block when:

  * expanding a partial (src/partial.rs)  -- fixes #756
  * entering a {{#with}} block (src/helpers/helper_with.rs)  -- fixes #592

Block params declared with `as |v k|` are deliberately NOT inherited,
as they are scoped to their block (matching Handlebars.js). A nested
{{#each}} inside a partial still sets its own @key/@index, so there is
no leak.

Add an immutable getter BlockContext::local_variables() to enable the
clone. Add regression tests covering object/array iteration, @first/
@last/@index, nested each resetting key, chained partials, and the
no-leak case outside any loop.

8 of 8 new or added lines in 3 files covered. (100.0%)

1701 of 2001 relevant lines covered (85.01%)

7.98 hits per line