valkyrjaio / sindri-java / 27920061701

100%

push

github

[Generation] Fix HTTP routing data and framework-provider resolution (#31)

# Description

Generating the application's `App*Data` files revealed the generated
output diverging badly from the PHP generator's. This fixes four bugs in
the AST readers and file generators so the generated HTTP routing and
container data are correct and complete.

- **HTTP route values were not real suppliers.** `routes()` emitted
`"version", version` — a bare, undefined identifier that does not
compile — instead of a `Supplier<RouteContract>`. It now builds `() ->
new Route(...)` with the handler method-reference and request methods.
- **`HEAD` was dropped from `paths()`.** PHP includes it; the skip is
removed.
- **Dynamic routes were not generated.** `{placeholder}` routes are now
detected, `@Parameter` / `@Parameters` are read (resolving `Regex.*`
constants), the match regex is precomputed by running the real framework
`Processor` (so it can never drift from runtime), and a `DynamicRoute`
supplier plus `dynamicPaths()` / `regexes()` are emitted.
- **`AppContainerData` was missing framework providers (~36 of ~40
callbacks).** Provider resolution only handled the app namespace and
recursed one level, so framework providers (`io.valkyrja.*`, reached via
`HttpApplicationComponentProvider`) were skipped. It now resolves
framework `.java` from the valkyrja sources jar on the classpath (the
portable equivalent of PHP's `ReflectionClass::getFileName()`) and
recurses the whole component-provider graph.

The end-to-end generate test previously only asserted the four files
exist. It now asserts the generated content (route suppliers, `HEAD`,
dynamic routes + regexes, framework-provider publishers) and that the
generated file parses as valid Java.

---

## Types of Changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(bre... (continued)

354 of 354 branches covered (100.0%)

Branch coverage included in aggregate %.

168 of 168 new or added lines in 5 files covered. (100.0%)

1133 of 1133 relevant lines covered (100.0%)

4.27 hits per line