gofogo / k8s-sigs-external-dns-fork / 27917521330
81%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 157
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.801% (-0.6%) from 81.36%
27917521330

push

github

web-flow 
feat(registry): new CRD option (#5372)

* feat(registry): new CRD option

* code & test self review

* align crd registry with others in the factory

* change from REST API to client/cache pattern

* refactor(registry/crd): address review feedback

- rename package registry -> crd to match its directory and drop the
  now-redundant import alias in the factory
- remove dead IsEndpoint() and EndpointLabels() methods
- fix DNSRecordSpec doc comment (DNSEndpoint -> DNSRecord) and drop the
  redundant +groupName marker already declared at package level
- rename the singular field's JSON tag endpoints -> endpoint and
  regenerate the CRD manifests
- exercise a distinct UpdateOld endpoint in the ApplyChanges update test

* fix(registry/crd): prevent DNSRecord name collisions

The object name was built as <dashed-dns-name>-<type>, which collapsed
distinct endpoints onto the same name: different set identifiers
(Route53 weighted/latency), sub.example.io vs sub-example.io, and names
truncated to the length limit. Colliding creates were silently swallowed
via IsAlreadyExists, so records were never stored.

Build a deterministic, RFC 1123 compliant name from a readable dashed DNS
prefix plus a short hash of the full identity (DNS name, record type, set
identifier). The dashed prefix keeps records discoverable with
`kubectl get dnsrecords`; the hash guarantees uniqueness.

Record identity now lives in the object name instead of labels, so lookups
Get-by-name rather than match labels. This also fixes DNS names longer than
63 characters, which previously overflowed the label-value limit and broke
create/lookup/delete. Only the owner label remains.

Add printer columns (DNS name, type, set identifier, targets) so the full
domain stays visible regardless of the object name.

* docs(registry/crd): note CRD registry uses txt-owner-id

The --txt-owner-id flag also identifies the instance for the CRD registry,
but its help text only mentioned TXT and DynamoDB. Add CRD so ... (continued)

17390 of 21522 relevant lines covered (80.8%)

1448.93 hits per line

Coverage Regressions

Lines Coverage ∆ File
77
0.0
 0.0% v1alpha1/zz_generated.deepcopy.go
34
89.25
 0.39% coredns/coredns.go
Jobs
ID Job ID Ran Files Coverage
1 run-ubuntu-latest - 27917521330.1 157
80.8
 GitHub Action Run
2 run-macos-latest - 27917521330.2 157
80.8
 GitHub Action Run
Source Files on build 27917521330