anthonypdawson / vector-inspector / 27908204525

80%

master: 80%

Build Type

push

github

Committed by anthonypdawson

Commit Message

fix: address all critical review issues from PR #39

Fixes blocking issues identified by Copilot and ChatGPT reviews:

**Critical Fixes (Phase 1):**
- Fix potential deadlock: Change Lock to RLock for re-entrant locking
- Add missing log_info import in lancedb_connection
- Fix cache poisoning: Don't cache fallback when no schema provided
- Fix broken test mock: Use _client instead of conn in pgvector test
- Remove unused imports from test files (pytest, MagicMock, patch, numpy)

**Quality Improvements (Phase 2):**
- Fix misleading UI label: Show "(manual override)" vs "(auto-detected)"
  - Added is_content_column_overridden() method to track manual changes
  - UI now correctly reflects the source of the content column name
- Fix performance issue: Use table.schema instead of to_pandas() for schema detection
  - Avoids loading entire table just to get column names/types
- Fix QThread leak: Connect finished → deleteLater in Ollama model fetch

**Test Results:**
- All 32 affected tests passing
- No regression in test coverage
- All review comments addressed

Related: PR #39 - Dynamic content column detection + Ollama embedding

Coverage Stats

9 of 15 new or added lines in 4 files covered. (60.0%)

4 existing lines in 2 files now uncovered.

15301 of 19065 relevant lines covered (80.26%)

0.8 hits per line