kubernetes-sigs / kubebuilder / 27897537671

84%

push

github

🐛 fix(helm/v2-alpha): strip custom volumes from manager template to prevent duplication (#5764)

fix(helm/v2-alpha): strip custom volumes from deployment object to prevent duplication

Custom volumes (e.g. user-added configMaps, secrets) appeared both as
literal entries in the generated manager.yaml template AND via
{{ toYaml .Values.manager.extraVolumes }}, causing duplication at install time.

The fix is in the extractor: after ExtractDeploymentConfig extracts custom
volumes into ValuesConfig, StripCustomVolumes removes them from the
deployment object. Since yaml.Marshal runs on the cleaned object, custom
volumes never appear in the template — they only flow through values.yaml.

System volumes (webhook-certs, metrics-certs) are kept in the object so they
render as conditionals in the template.

Manager container resolution now uses the kubectl.kubernetes.io/default-container
annotation (falling back to "manager", then containers[0]), consistent with
the templater's GetDefaultContainerName. The annotation key and fallback name
are lifted into the shared common package so both resolvers reference the
same constants.

Related: 5718

49 of 58 new or added lines in 3 files covered. (84.48%)

7887 of 9497 relevant lines covered (83.05%)

85.33 hits per line