SAP / cloud-foundry-tools / 27896922723

91%

master: 97%

push

github

fix: fall back to direct CF lookup when UPS not found in list (#311)

When binding a grantor service to a UPS, the CF Cloud Controller list
API has eventual consistency — a newly created (or recently updated)
instance may not appear in GET /v3/service_instances immediately, even
though it exists. The requstedInstance code path threw immediately on a
list miss with no fallback, causing sporadic bind failures.

Fix: if the instance is not found in the available-services list, retry
via getServiceInstanceInfo() (a direct metadata lookup by name) before
throwing. If found, inject the result into availableServices so the
subsequent instance-resolution loop does not issue a redundant second
fetch. Tests updated accordingly.

Fixes: https://jira.tools.sap/browse/DEVXBUGS-12663

866 of 968 branches covered (89.46%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

1047 of 1124 relevant lines covered (93.15%)

17.93 hits per line