codebar / planner / 27895098245

95%

master: 95%

Pull #2658

github

Remove EligibilityInquiry before_save callback, dispatch mailer from controller

EligibilityInquiry had a before_save callback that dispatched
MemberMailer.eligibility_check synchronously on every record creation.
The mailer dispatch belongs to the orchestrator (the controller action),
not the domain model.

Changes:
- Remove before_save :send_email callback and send_email method from
  app/models/eligibility_inquiry.rb
- Inline MemberMailer.eligibility_check in Admin::MembersController
  #send_eligibility_email after create!
- Remove callback-driven email test from model spec
- Add controller spec verifying record creation, mailer dispatch, and
  redirect

5 of 5 new or added lines in 2 files covered. (100.0%)

3548 of 3722 relevant lines covered (95.33%)

42.28 hits per line