codebar / planner / 27894728429

95%

master: 95%

Pull #2658

github

Move mailer dispatch from FeedbackRequest callback to rake task caller

FeedbackRequest had an after_create callback that dispatched
FeedbackRequestMailer.request_feedback synchronously. This meant
every record creation — from the rake task, the console, or a
migration — sent an email as an invisible side-effect.

The responsibility for dispatching the mailer belongs to the
orchestrator (the rake task), not the domain model. The model
should create the record; the caller decides what happens next.

Changes:
- Remove after_create :email callback and email method from
  app/models/feedback_request.rb
- Inline mailer dispatch in lib/tasks/feedback.rake, replacing
  the unused `map` with `each`
- Remove model spec for callback-driven email sending
- Update rake spec to verify both record creation and mailer
  dispatch with correct arguments

Tests: 1040 examples, 0 failures

3 of 3 new or added lines in 2 files covered. (100.0%)

3554 of 3728 relevant lines covered (95.33%)

42.2 hits per line