valkyrjaio / sindri-ts / 27894710868

100%

push

github

[Sindri] Fix config data-path resolution (#30)

# Description

Sindri generated data into the wrong directory. An application `Config`
declares `dir: process.cwd()` (the app root at runtime) and `dataPath:
'src/App/Cli/Data'` (relative to that root), but the reader resolved
`process.cwd()` to the config file's own directory and then joined the
app-root-relative `dataPath` on top — producing
`src/App/Cli/src/App/Cli/Data/...` instead of `src/App/Cli/Data`.
Generation reported success but wrote to a nested junk path.

This resolves `process.cwd()` to the actual working directory (Sindri
runs from the app root, the same place the application runs from,
mirroring PHP's app-root `dir`), so the data path lands correctly. It
also makes the source-file search skip `node_modules`, since searching
from the app root must not match (or be slowed by) framework classes
that share a basename with app classes.

Verified end-to-end: the CLI now writes all four `App*Data.ts` files
into the correct data directory with no stray output.

---

## Types of Changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`src/Sindri/Ast/ConfigReader.ts`** — `resolvePathFromArg` now
returns the real `process.cwd()` for a `process.cwd()` dir argument
instead of the config file's directory
- **`src/Sindri/Generate/Abstract/GenerateDataFromAst.ts`** —
`findFileInDir` now skips `node_modules` directories while recursing
- **`tests/Tests/Unit/Ast/ConfigReader.test.ts`** — updated the
`process.cwd()` case to assert `dir === process.cwd()`
- **`tests/Tests/Unit/Generate/Abstract/GenerateDataFromAst.test.ts`** —
added a test that source files insi... (continued)

697 of 697 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

1130 of 1130 relevant lines covered (100.0%)

10.93 hits per line