Geoffery10 / Discord-Role-Manager / 27891208327

90%

push

github

Add test_dashboard_helpers.py — dashboard/main.py helpers at 30% coverage

13 tests covering the pure helpers and schema migration in
dashboard/main.py. The route handlers (Phase 11) and OIDC discovery
remain uncovered — they need full ASGI scaffolding.

  db_conn()
    - returns a sqlite3.Connection with busy_timeout=5000 set

  read_json() / write_json()
    - read returns {} when file is missing (not None, not raise)
    - read parses existing JSON
    - write creates files with indent=4 (matches existing config style)
    - write overwrites existing files

  _get_git_commit()
    - returns the short SHA from git rev-parse
    - returns 'unknown' sentinel when git fails (so the dashboard
      still renders rather than crashing the page)

  _get_server_ip()
    - filters loopback and IPv6 from getaddrinfo results
    - falls back to the UDP probe (10.254.254.254:1 trick) when
      only loopback comes back
    - returns 'unknown' when both strategies fail

  _ensure_schema()
    - no-op when users table doesn't exist (fresh checkout)
    - adds avatar column to legacy users table
    - rebuilds guilds with id as PRIMARY KEY and dedupes via
      MIN(name) — same migration logic as iDiscord._ensure_schema

Dashboard main went from 0% to 30%. The remaining 70% is the 29
FastAPI route handlers (auth, users, roles, guilds, birthdays,
logs) plus OIDC discovery — covered by Phase 11.

Importing dashboard.main has heavy side effects (FastAPI app build,
subprocess git call, socket probe). The dashboard_main fixture
patches socket.getaddrinfo and socket.socket at module scope and
restores them on teardown so other tests aren't affected.

120 of 120 new or added lines in 1 file covered. (100.0%)

2161 of 2670 relevant lines covered (80.94%)

0.81 hits per line