Geoffery10 / Discord-Role-Manager / 27890456328

90%

Build Type

push

github

Committed by Geoffery10

Commit Message

Add test_main.py — main.py pure helpers now at 35% coverage

8 tests covering the two pure functions in main.py:

  load_roles(path='roles.json')
    - reads the guild-scoped {guild_id: {emoji: role_id}} format
    - upgrades the legacy flat {emoji: role_id} format to guild-scoped
      under the canonical main guild id (254779349352448001)
    - respects a custom path argument

  flatten_roles(roles_dict)
    - flattens nested {guild_id: {emoji: role_id}} → {emoji: role_id}
    - coerces string role_ids (from JSON) to int for use as discord IDs
    - passes int role_ids through unchanged
    - returns {} for empty input
    - keeps the last value when two guilds define the same emoji key
      (pins this documented behavior)

main.py went from 0% to 35%. The remaining 65% is the MyClient
event handlers and slash commands (add_birthday, next_birthday,
update_db) which need an active discord gateway to exercise properly
— out of scope for this phase.

Note: main.py contains DUPLICATED definitions of load_roles and
flatten_roles (lines 26-32 and 34-39 are dead code; Python uses
the definitions at lines 42-48 and 51-56). Worth cleaning up in a
follow-up commit.

Importing main.py has module-level side effects (reads roles.json,
calls client.run(TOKEN)). The roles_json fixture writes a roles.json
into a tmp dir, and the import_main fixture monkeypatches
discord.Client.run to a no-op so the module can be imported in a
test environment without spinning up a real bot.

Coverage Stats

56 of 56 new or added lines in 2 files covered. (100.0%)

4 existing lines in 1 file now uncovered.

1615 of 2357 relevant lines covered (68.52%)

0.69 hits per line