decentraland / signatures-server / 27883783332

91%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: migrate well-known-components to @dcl core components (#482)

* refactor: migrate well-known-components to @dcl core components

replace the @well-known-components/* packages that have equivalents in the
core-components and core-libs monorepos:

- http-server, metrics, pg-component, thegraph-component and
  http-tracer-component move to their @dcl/* counterparts
- the local fetch, job and schema-validator ports are removed in favour of
  @dcl/traced-fetch-component, @dcl/job-component and
  @dcl/schema-validator-component
- decentraland-crypto-middleware is replaced by @dcl/crypto-middleware
- ifetchcomponent / ihttpservercomponent are re-sourced from @dcl/core-commons

the metrics endpoint is now wired explicitly via
instrumenthttpserverwithpromclientregistry, the pg migration options drop
databaseurl, and @well-known-components/interfaces is bumped to ^1.5.2 so the
pg/job lifecycle symbols fire. node-fetch is added as a dev dependency because
@well-known-components/test-helpers requires it at runtime.

note: the schema validator now returns 415 (instead of 400) when a request is
sent without a json content-type.

* refactor: address review feedback on core-components migration

- guard metrics.registry instead of asserting non-null, so a missing
  prom-client registry fails fast with a clear message instead of a
  masked undefined
- drop the "dom" tsconfig lib and bump @types/node to ^20, which provides
  the native fetch globals (request/response) used by @dcl/core-commons
  without exposing browser globals (window, document, localstorage) to
  server-side code

Coverage Stats

335 of 362 branches covered (92.54%)

Branch coverage included in aggregate %.

6 of 22 new or added lines in 4 files covered. (27.27%)

2 existing lines in 1 file now uncovered.

650 of 715 relevant lines covered (90.91%)

40.32 hits per line