decentraland / catalyst-client / 27881332047

70%

master: 70%

push

github

feat!: build deployments with web-standard FormData (#489)

* feat!: build deployments with web-standard FormData

deploy() now builds the multipart body with the web-standard FormData and Blob
(global in browsers and Node >= 18) instead of the node `form-data` package,
appending file contents as Blobs for both node and browser (the node/browser
branch and the form-data dependency are gone).

When the resulting form is used as a request body, native fetch (and node-fetch
v3) set the multipart Content-Type with the boundary automatically, so
deployments now work with a native-fetch fetcher without relying on node-fetch's
form-data handling.

BREAKING CHANGE: deploy() requires the injected fetcher to support web-standard
FormData request bodies (native fetch, node-fetch v3, or a browser fetch).
Fetchers built on node-fetch v2 no longer serialize the deployment body
correctly.

* refactor: go fully native for fetch and drop node-fetch deps

Follow-up to the web-standard FormData deploy change, completing the move off
node-fetch in the client.

- default fetcher now uses @dcl/fetch-component (native, with the same
  retry/timeout behaviour) instead of @well-known-components/fetch-component
  (which was node-fetch v2 via cross-fetch). Updated the build snapshot script
  and tests accordingly.
- drop the now-unused direct dependencies @well-known-components/fetch-component
  and cross-fetch.
- declare engines.node >= 18 (the client now relies on global fetch/FormData/Blob).
- remove the dead, non-exported isNode() helper.
- enable skipLibCheck (the @dcl/core-commons type declarations pulled in via
  @dcl/fetch-component reference jest types in their published mocks).

* fix: return Uint8Array from downloadContent for browser compatibility

downloadContent built its result with Buffer (Node-only), which breaks the
client in the browser. Use the web-standard Uint8Array instead — hashV0/hashV1
already accept it, and Buffer was the only Node-only API left in sr... (continued)

147 of 224 branches covered (65.63%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

320 of 442 relevant lines covered (72.4%)

19.87 hits per line