trickstercache / trickster / 27879931985

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix: [engines] set Request.GetBody to support HTTP/2 GOAWAY retries (#1020)

POST/PUT requests returned 502 Bad Gateway when the upstream sent an HTTP/2 GOAWAY frame (keep-alive rotation, rolling updates). Go's transport only retries such requests when Request.GetBody is set, so without it the transport could not re-read the body and aborted the retry with "cannot retry err after Request.Body was written; define Request.GetBody to avoid this error".

PrepareFetchReader now buffers the request body via request.GetBody, which bounds the read by the backend's MaxObjectSizeBytes (returning 413 when exceeded) and caches it on the request resources, then mirrors it into Request.GetBody so the transport can replay the body on retry.

Tests cover body replay across multiple GetBody calls, the end-to-end GOAWAY retry, and 413 rejection of an oversized body.

Signed-off-by: thinker0 <thinker0@gmail.com>

Coverage Stats

21 of 23 new or added lines in 1 file covered. (91.3%)

9 existing lines in 2 files now uncovered.

20714 of 23253 relevant lines covered (89.08%)

1.55 hits per line