kubeovn / kube-ovn / 27870594903

26%

master: 27%

Build Type

push

github

Committed by oilbeater

Commit Message

fix(ovs): make DeleteNat idempotent when target NAT row is absent (#6911)

DeleteNat used to return an error ("not found logical router ... nat ...")
when GetNat returned no row. This caused problems for callers such as
the OvnFip delete handler, which could then fail to clear its finalizer
and requeue forever.

Change GetNat to ignore-not-found and return success (nil) if the NAT
row is already gone. This matches the pattern used elsewhere and lets
reconciles proceed cleanly.

A regression test is added to verify both the never-existed case and
double-delete after create.

Signed-off-by: Apinant U-suwantim <Hello@Apinant.dev>
(cherry picked from commit b1cccbd38)

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

14447 of 56806 relevant lines covered (25.43%)

0.3 hits per line