valkyrjaio / valkyrja-starter-app-ts / 27863937280

100%

push

github

[Application] Align structure with PHP and Java and add a full unit test suite (#42)

# Description

`application` had no test suite (coverage reported `0/0`) and had
drifted structurally from the PHP and Java applications. This PR brings
it in line with the other ports and to 100% line, branch, and function
coverage (55 tests), so all three language apps now match in structure
and coverage.

Two things were going on:

1. **Structural drift from PHP/Java.** The route providers were named
`RouteProvider` instead of `CliRouteProvider` / `HttpRouteProvider`, the
`Http/App` entry was missing, and the Http app carried an orphan
`AppCliRoutingData` that neither PHP nor Java has. The imperative
`getRoutes()` routing model is intentionally kept — TS has no
decorators/attributes, so there is no `getControllerClasses()`, matching
how Go and Python will work too. The intentionally-unported `Model` /
`Orm` / `Throwable` modules are left out, consistent with the Java app.

2. **Broken test setup.** `vitest.config.ts` used a relative
`../../../tests` glob with no root, so coverage measured nothing — the
same misconfiguration already fixed in `valkyrja` and `sindri`.

---

## Types of Changes

- [x] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`src/App/Cli/Provider/CliRouteProvider.ts`** — renamed from
`RouteProvider.ts`; class renamed `RouteProvider` → `CliRouteProvider`
to match PHP/Java
- **`src/App/Http/Provider/HttpRouteProvider.ts`** — renamed from
`RouteProvider.ts`; class renamed `RouteProvider` → `HttpRouteProvider`
- **`src/App/Cli/Provider/ComponentProvider.ts`** /
**`src/App/Http/Provider/ComponentProvider.ts`** ... (continued)

8 of 8 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 3 files covered. (100.0%)

72 of 72 relevant lines covered (100.0%)

1.76 hits per line