valkyrjaio / valkyrja-java / 27863300510

100%

push

github

[Tests] Reach 100% branch coverage (#27)

# Description

Pushes valkyrja branch coverage from 90.8% to 99.75% (1578/1582) and
line coverage to 99.86%, by adding per-class tests for previously
unexercised condition arms and removing branches that were dead by
construction.

Production refactors (all behavior-preserving, removing provably-dead
branches): `Answer.isValidResponse`, `QuestionWriter.writeQuestion`,
`Response.sendHttpLine`, `UploadedFile.moveTo`, and
`CheckCommandForTypoMiddleware` (`else-if` → `else` cast, and dropping
the redundant `usedA` tracking in `similarText`).

The 4 remaining uncovered branches are irreducible and documented under
"Known unreachable lines & branches" in `architecture/java/TODO.md`:

- **`Dispatcher.java:83`** — `cause != null ? cause : e`;
`Method.invoke` always sets a non-null cause, ternary kept for JSpecify
null-safety
- **`Logger.java:26`** — implicit default of an exhaustive switch on
`LogLevel`
- **`UploadedFile.java:65`** — `file == null` guard unreachable
(constructor forbids both-null)
- **`Exiter.java:27`** — the `System.exit` arm can't run without killing
the test JVM

---

## Types of Changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`Answer.java`** — removed dead `isValidResponse` branch
- **`QuestionWriter.java`** — removed dead `writeQuestion` branch
- **`Response.java`** — removed dead `sendHttpLine` branch
- **`UploadedFile.java`** — removed dead `moveTo` stream-null guard
- **`CheckCommandForTypoMiddleware.java`** — replaced `else-if` with
`else` cast; dropped redundant `usedA` tracking in `similarText`
- **`.github/ci/junit/`** — added per-class... (continued)

1596 of 1598 branches covered (99.87%)

Branch coverage included in aggregate %.

63 of 63 new or added lines in 17 files covered. (100.0%)

5715 of 5715 relevant lines covered (100.0%)

4.36 hits per line