valkyrjaio / valkyrja-ts / 27862115990

100%

push

github

[Tests] Reach 100% branch coverage (#51)

# Description

Drives the `valkyrja` TypeScript package to 100% line coverage, 100%
function coverage, and 99.56% branch coverage (the remaining branches
are genuinely-unreachable TypeScript compiler artifacts — see note
below). Coveralls aggregates line + branch coverage, bringing the
reported aggregate to ~99.86%.

While covering the branches, a real bug was surfaced and fixed:
`Header.getHeaderLine()` was returning `"Name: value"` instead of just
the value. PHP's `Header::getHeaderLine()` returns values only
(`__toString()` is the one that prefixes the name). The TypeScript port
had conflated the two, which meant `RequestHandler` wrote the wrong
value to real HTTP responses (`nodeResponse.setHeader('X-Test', 'X-Test:
value')`) and `RedirectResponse.back()` threw on any real `Referer`
header because the malformed line was fed into
`UriFactory.fromString()`. The fix restores parity with PHP and
unblocked covering `back()`'s internal/external-referer branches.

The remaining branch gaps were closed with targeted tests
(default-argument fallbacks, both sides of ternaries, switch
fall-throughs, guard else-paths, and protected-method edges exercised
via small test subclasses), plus a handful of behavior-identical,
branchless source rewrites that bring the code closer to the PHP source
and remove dead defensive branches.

**Closing the final 7 branches to reach true 100%:** all 7 were
genuinely-unreachable defensive/compiler artifacts resolved with
behavior-preserving refactors — no `/* v8 ignore */` annotations were
added, keeping parity with the project's convention of never using
coverage-ignore comments.

- **Enum namespace merge** — `BackgroundColor`, `TextColor`, and `Style`
attached their `getDefault()` helper via `export namespace`, which
compiles to a second IIFE guarded by `X || (X = {})`. Because the enum
always defines `X` first, the `|| (X = {})` arm can never execute.
Converted to standalone exported... (continued)

1578 of 1578 branches covered (100.0%)

Branch coverage included in aggregate %.

28 of 28 new or added lines in 14 files covered. (100.0%)

3405 of 3405 relevant lines covered (100.0%)

20.06 hits per line