AAEmu / AAEmu / 27862010063

5%

Build Type

push

github

Committed by web-flow

Commit Message

feat(game): broadcast dice roll results via dedicated SCDiceValuePacket packet (#1452)

* fix(game): correct dice roll range, parsing, and invalid input handling

Roll range was exclusive of max instead of inclusive. The client's
max was read as uint and round-tripped through a string into an int,
which threw OverflowException for any value above int.MaxValue.
Read max directly as a signed int32 instead, and reject max < 1 so
Random.Next can't be called with an invalid range. Roll via
Random.Next(0, max) + 1 rather than Next(1, max + 1) so max can be
as large as int.MaxValue without max + 1 overflowing to int.MinValue.

* feat(game): broadcast dice roll results via dedicated packet

Replaces the chat-message broadcast for /roll with a new
SCDiceValuePacket carrying the player name, max, and rolled value.

Coverage Stats

4 of 12 new or added lines in 3 files covered. (33.33%)

5 existing lines in 2 files now uncovered.

1318 of 24410 relevant lines covered (5.4%)

0.13 hits per line