valkyrjaio / ci-rector-php / 27857717593

100%

push

github

[Tests] Adding missing tests (#85)

# Description

Brings the Rector package to 100% test coverage and refactors
`RemoveNonConflictingAliasInUseStatementRector` so every branch is
reachable and covered by its own dedicated test.

The rector's `refactor()` previously combined file-node and namespace
handling and nested its class-like checks inside a multi-line
parenthesized condition. That shape left branches awkward to exercise
and produced a coverage artifact under newer PHPUnit/Xdebug (a bare `(`
on its own line counted as an uncoverable statement). The logic is split
into clearer paths and the parenthesized `instanceof` group is extracted
into a local boolean, so the file reaches 100% line coverage by its own
test alone. No behavior changes.

---

## Types of Changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

-
**`src/Rector/CodingStyle/Rector/Stmt/RemoveNonConflictingAliasInUseStatementRector.php`**
— split `FileNode` and `Namespace_` handling into separate paths;
extracted the `Class_` / `Interface_` / `Trait_` / `Enum_` check into a
`$isClassLike` local, removing the multi-line-condition coverage
artifact
-
**`tests/Tests/Unit/CodingStyle/Rector/Stmt/RemoveNonConflictingAliasInUseStatementRectorTest.php`**
— added a dedicated unit test exercising the rector's node logic
directly
-
**`tests/Tests/CodingStyle/Rector/Stmt/RemoveNonConflictingAliasInUseStatementRectorTest.php`**
/
**`tests/Fixture/RemoveNonConflictingAliasInUseStatementRector/*.php.inc`**
/ **`tests/config/`** — added Rector integration fixtures (trait use,
enum/import conflicts, type declarations, two-removable-aliases, skip
cases)
- *... (continued)

5 of 5 new or added lines in 1 file covered. (100.0%)

137 of 137 relevant lines covered (100.0%)

7.8 hits per line