GrottoCenter / grottocenter-api / 27845930826

88%

develop: 88%

Build Type

Pull #1693

github

Committed by ClemRz

Commit Message

fix(unit): address code review feedback

- Add UNIQUE constraint on t_unit.symbol (prevents row fanout in view joins)
- Remove duplicate ‰ fixture (keep per_mil id=29, drop PER_MIL id=3)
- Keep value_si NULL guard (mislabeled SI value is worse than no value)
- Add defensive fallback before SET NOT NULL on id_display_unit
- Expand comment on mg/L pragmatic SI convention
- Rename DB columns factor_to_si/offset_to_si → si_to_display_factor/si_to_display_offset
  (aligns SQL and JS naming, no ambiguity on conversion direction)

Pull Request Pull Request #1693: refactor(unit): move SI conversion factors from quantity kind to unit

Coverage Stats

4567 of 5440 branches covered (83.95%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 3 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

8581 of 9524 relevant lines covered (90.1%)

137.91 hits per line