ultimate-notion / ultimate-notion / 27837611786

87%

push

github

Remove wrap_obj_ref covariance type: ignore by widening to GenericObject (#229)

The `wrap_obj_ref` `[misc]` ignore came from a covariant TypeVar `GT_co`
appearing in an input position. Fix the root cause: make the shared
`_obj_api_map` registry honestly keyed by `type[GenericObject]` (it was
never coherent to key a shared ClassVar by a per-subclass TypeVar), widen
`wrap_obj_ref`'s param to `GenericObject` (the concrete class is resolved
at runtime via the registry), and apply a covariant-self upcast on
`__init__` for the `_obj_ref` build assignment.

Adapt the consumers: drop `Page.wrap_obj_ref` in favour of the
`_finalize_wrap` hook; widen `OptionGroup`/`TableRow` overrides (the latter
gains a runtime type guard the registry already guarantees); delete the
dead, now-untypeable `_obj_api_type` property.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

14 of 16 new or added lines in 4 files covered. (87.5%)

6509 of 7403 relevant lines covered (87.92%)

6.13 hits per line