ultimate-notion / ultimate-notion / 27835540209

87%

push

github

Drop obj_ref setter covariance type: ignore via a covariant self-view (#226)

`Wrapper.obj_ref`'s setter took the covariant `GT_co`, which is unsound in an
input position and required a `# type: ignore[misc]`. Both `self` and the value
are now typed against `GenericObject` (the upper bound of `GT_co`); annotating
`self: Wrapper[GenericObject]` is a sound upcast because `Wrapper` is genuinely
covariant, so the assignment to `_obj_ref` type-checks without a cast. The
getter still narrows reads to `GT_co`. `Relation` overrides the getter and thus
re-declares the setter, so it gets the same widening to stay contravariant with
the base. Annotation-only: no runtime change, no new mypy/ruff errors.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2 of 2 new or added lines in 2 files covered. (100.0%)

6510 of 7403 relevant lines covered (87.94%)

6.13 hits per line