decentraland / catalyst-client / 27834761088

70%

push

github

feat: accept both well-known-components and core-commons fetch components (#488)

* feat: accept both well-known-components and core-commons fetch components

The client depended on `IFetchComponent` from
`@well-known-components/interfaces`, which is built on `node-fetch` types.
That interface is structurally incompatible with the native-fetch
`IFetchComponent` from `@dcl/core-commons` (node-fetch `Request`/`Response`
carry members the global undici types lack, and vice-versa), so neither
fetcher could be passed where the other was expected.

Depend on the narrow structural subset both fetchers satisfy instead:

- Define local `IFetchComponent`, `RequestOptions` and `FetchResponse` in
  `client/types.ts`, keyed on string URLs and reading only
  `json()`/`arrayBuffer()` off the response.
- Repoint the internal imports away from `@well-known-components/interfaces`.
- Replace the node-fetch-only `.buffer()` call with
  `Buffer.from(await res.arrayBuffer())`, which works on both responses.
- Export the new fetch types from the package entry point.
- Update the download test mocks to expose `arrayBuffer()`.

No new dependency is added, and existing consumers passing a
well-known-components fetcher keep working.

* refactor: address review comments

- Import IFetchComponent from the package (../src) in tests instead of
  @well-known-components/interfaces, validating the local type end-to-end.
- Split the nested await in downloadContent into two statements for
  readability.

152 of 231 branches covered (65.8%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

327 of 451 relevant lines covered (72.51%)

19.51 hits per line