GrottoCenter / grottocenter-api / 27832060872

88%

develop: 88%

Build Type

Pull #1691

github

Committed by ClemRz

Commit Message

fix(substance): address code review findings on PR #1691

- Remove duplicate unique index (constraint already creates one)
- Wrap DDL sections 3-5 in BEGIN/COMMIT for atomicity
- Change external_source DEFAULT to NULL (was 'PubChem')
- Replace case-sensitive UNIQUE constraint with LOWER() functional index
- Remove dead externalSource derivation from controller
- Add length validation for formula, casNumber, externalId
- Unify create response path (201 for new, 200 for existing)

Pull Request Pull Request #1691: feat(substance): add t_substance reference table with PubChem integration

Coverage Stats

4541 of 5412 branches covered (83.91%)

Branch coverage included in aggregate %.

131 of 145 new or added lines in 10 files covered. (90.34%)

2 existing lines in 1 file now uncovered.

8545 of 9488 relevant lines covered (90.06%)

136.13 hits per line