mozilla-releng / balrog / #5609

90%

push

circleci

releases: avoid mutating a cached object (#3830)

In get_release, copy the base blob before merging assets into it, to
avoid modifying a shared object.
This was causing extra memory usage
(https://bugzilla.mozilla.org/show_bug.cgi?id=2014991#c6), because the
releases cache ended up storing unwanted release assets.  And would
cause a data race if/when we set UWSGI_THREADS to >1, with multiple
request handlers modifying that object
(https://bugzilla.mozilla.org/show_bug.cgi?id=2003549#c7).

2192 of 2574 branches covered (85.16%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

5768 of 6276 relevant lines covered (91.91%)

0.92 hits per line