safe-global / safe-client-gateway / 27824890665

90%

push

github

fix: tolerate client/server clock skew when validating SiWe message t… (#3173)

SiWe login intermittently failed with 401 "Invalid message" immediately after signing, then succeeded after waiting ~1 minute. Root cause: the SiWe message time bounds (issuedAt, expirationTime, notBefore) were compared against the server clock with zero tolerance. When
the client clock runs ahead of the server clock (clock skew), a freshly-signed message's issuedAt is in the future relative to the server and is rejected as "Message yet issued" until the server clock catches up.

This adds a configurable clock-skew allowance, applied symmetrically to the three time bounds, mirroring the leeway used by JWT/OIDC validators. Replay protection and freshness remain enforced independently by the single-use, TTL-bound nonce, so the tolerance does not weaken those
guarantees.

4616 of 5485 branches covered (84.16%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 2 files covered. (100.0%)

17089 of 18545 relevant lines covered (92.15%)

629.73 hits per line