ultimate-notion / ultimate-notion / 27824350974

87%

push

github

Drop metaclass type: ignores by moving get_db/to_dict/_set_obj_refs onto SchemaType (#214)

The `SchemaType.__setitem__`/`__setattr__` dunders annotated `cls` as
`type[Schema]`, which is incompatible with the metaclass self type and forced
`type: ignore[misc]`. They used that annotation only to reach `get_db` and
`_set_obj_refs`, which lived on `Schema` as classmethods.

Move `get_db`, `to_dict`, and `_set_obj_refs` onto the `SchemaType` metaclass
(alongside the other property-operating methods), drop the `cls: type[Schema]`
annotations, and widen the internal schema-class reference (`Property._owner`,
`_get_owner`, `SchemaNotBoundError`) to `SchemaType`. This removes three
`type: ignore[misc]` comments and an unnecessary `cast`.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

18 of 19 new or added lines in 2 files covered. (94.74%)

6513 of 7405 relevant lines covered (87.95%)

6.13 hits per line