btcsuite / btcd / 27794794665

52%

master: 52%

Pull #2554

github

btcutil: vendor anet instead of depending on a personal fork

In this commit, we vendor the Android networking shim that backs
InterfaceAddrs on android into the btcutil module, rather than
importing it from github.com/kcalvinalvin/anet. The shim works around
golang/go#40569, where net.InterfaceAddrs fails with
"route ip+net: netlinkrib: permission denied" on Android 11 and later
because of the tightened restrictions on NETLINK sockets. btcutil only
ever calls anet.InterfaceAddrs, wired in from net_android.go under the
android build tag.

The motivation is dependency hygiene. The previous import pointed at a
fork hosted under an individual contributor's account, which is not a
home we want a release dependency to live in. By copying the source
into internal/anet we drop the external module entirely: the package is
now unimportable from outside btcutil, and go.mod no longer references
the fork.

The source originates from github.com/wlynxg/anet, and its BSD 3-Clause
LICENSE travels with it. Unlike upstream, this copy does not reach into
the standard library's net package via //go:linkname; it carries its
own ipv6ZoneCache, so no -ldflags "-checklinkname=0" linker flag is
needed to build it. When golang/go#40569 is resolved upstream, both
this package and the net_android.go shim can be removed.

0 of 13 new or added lines in 2 files covered. (0.0%)

36075 of 69639 relevant lines covered (51.8%)

354221.38 hits per line