BacLuc / ecamp3 / 27784703470

36%

devel: 36%

push

github

fix(frontend): avoid resolving null user relation on loading collaborations

The _campRole computed in campRoleMixin called coll.user() on camp
collaborations to find the one belonging to the current user. The
`typeof coll.user === 'function'` guard was meant to skip invited
collaborators (whose `user` relation is null), and it works for loaded
resources: hal-json-vuex exposes a null relation as a plain null
property.

However, on a still-loading hal-json-vuex proxy every relation access
returns a function, so the guard passed for loading collaborations too.
Calling coll.user() then resolved to null once the collaboration
finished loading, rejecting the load promise with "Property 'user' ...
was used like a relation, but no relation with this name was returned by
the API (actual return value: null)" and surfacing as an unhandled
rejection in Sentry.

Skip still-loading collaborations before resolving .user(), and report
no role yet (null) while collaborations are loading. Add unit tests for
the mixin.

fixes https://github.com/ecamp/ecamp3/issues/10085

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: BacLuc <lucius.bachmann@clubpage.ch>

844 of 4748 branches covered (17.78%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

4865 of 11185 relevant lines covered (43.5%)

983.53 hits per line