stacklok / toolhive-studio / 27781625709

71%

main: 71%

Pull #2324

github

fix(newsletter): stop dismissal re-pop loop and add DB write observability

The newsletter modal re-pops because the dismissal is never persisted when the
SQLite write fails silently. First step of #2321:

- setNewsletterDismissedAt now reports whether the dismissal was actually
  persisted. The renderer suppresses the modal for the rest of the session only
  when it wasn't — stopping the in-session re-pop loop on a read-only DB or a
  failed write, while leaving the normal (persisted) flow unchanged.
- Instrument DB write failures in Sentry, separating Bucket A (read-only DB:
  on-disk schema newer than the app, captured in the migrator with applied vs
  known schema) from Bucket B (the write threw, captured with the SQLite error
  code). os.name / release are attached automatically. Today these failures are
  invisible — Bucket A doesn't even produce a local log.

Refs #2321

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

5240 of 8017 branches covered (65.36%)

13 of 23 new or added lines in 5 files covered. (56.52%)

7762 of 10956 relevant lines covered (70.85%)

114.86 hits per line