Logflare / logflare / a9bb10a5b97a036b21df949e1490fd89a103dd4f

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(clickhouse): log host on connection and query errors (#3611)

* feat(clickhouse): log host on connection and query errors

ClickHouse connection, query, insert, and provisioning error logs
previously carried only backend_id and the failure reason, making it
hard to identify which cluster/host was failing. The host was already
parsed from the config URL at each connection-setup site but never
threaded into the logs.

Add the host to the metadata of these error/warning logs. Read-path
logs use read_only_url (falling back to url); ingest-path logs use url.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(clickhouse): reuse fetched backend for start-failure host log

start_pool now fetches the backend once and passes it to both
build_ch_opts and the failure-path host derivation, removing the
second cache lookup that connection_host/1 performed on the
"Failed to start" path. The pool-died DOWN handler still resolves the
host from backend_id via the cache, since no backend is in scope there.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(clickhouse): include host in native ingester mock connection

The native insert error logs now read conn.host, but the opts-passthrough
tests passed a bare map as the pooled connection. Add :host so the mock
matches the real Connection struct shape.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

32 of 51 new or added lines in 6 files covered. (62.75%)

1 existing line in 1 file now uncovered.

13202 of 16271 relevant lines covered (81.14%)

5089.56 hits per line