adrienverge / yamllint / 27767771724

100%

push

github

linter: Report non-printable characters as a syntax error

Prevent yamllint crash upon unescaped (embedded) non-printable
characters:

    $ printf 'key: val\000ue\n' | yamllint -
    …
    yaml.reader.ReaderError: unacceptable character #x0000: special characters are not allowed
      in "<unicode string>", position 8

PyYAML raises a ReaderError for control characters such as NUL or DEL.
It is a YAMLError but, unlike the parser/scanner errors yamllint already
handles, not a MarkedYAMLError, so it escaped get_syntax_error() and
crashed the whole run. The same input also broke the token generator,
since BaseLoader() itself raises the error before any token is produced.

Catch ReaderError in get_syntax_error() and derive its line/column from
the flat buffer position, and tolerate it in token_or_comment_generator()
the same way ScannerError is, so cosmetic rules still run on the
printable lines. Such input is now reported as a regular syntax error.

19 of 19 new or added lines in 4 files covered. (100.0%)

4337 of 4345 relevant lines covered (99.82%)

5.99 hits per line