supabase / supabase-flutter / 27763779899

85%

Build Type

push

github

Committed by web-flow

Commit Message

chore(supabase): enable dispose-class-fields and dispose owned clients (#1419)

Stacked on #1417.

## What

Enables the `dispose-class-fields` DCM rule by properly tearing down the
client fields `SupabaseClient` owns.

- `SupabaseClient.dispose()` now disposes the `functions` and `rest`
clients (no-ops today since they share the parent isolate, but correct
by contract) and closes `_authHttpClient`.
- `_authHttpClient` is only closed when the SDK created the underlying
`Client` (i.e. the caller did not pass their own `httpClient`), so a
user-provided client is never closed out from under them.
- `AuthHttpClient.close()` now forwards to its inner client, so the
internally-created `Client()` is actually torn down. This fixes the leak
the rule was flagging (previously `BaseClient.close()` was a no-op and
the inner client was never closed).

## Verification

- `dcm analyze packages` -> no issues found.
- `dart analyze` clean.
- `supabase` package tests: 83 passing, unchanged from baseline.

Coverage Stats

6 of 6 new or added lines in 2 files covered. (100.0%)

181 existing lines in 10 files now uncovered.

4102 of 4784 relevant lines covered (85.74%)

3.48 hits per line