alma-oss / spirit-design-system / 27761024917

86%

main: 85%

Pull #2444

github

feat(web,web-react)!: remove `ControlButton` expanded size scale feature flag #DS-2216

Promote the expanded size scale to the default (and only) `ControlButton`
size scale, removing the `enable-v5-control-button-expanded-size-scale`
Sass flag and `spirit-feature-enable-v5-control-button-expanded-size-scale`
CSS class.

- Make the expanded size config the default in the web `ControlButton` theme
  (`xsmall`/`small`/`medium`/`large`/`xlarge`)
- Set `ScrollView` controls to the default `medium` size (restores their
  original 24px height under the new scale)
- Showcase all five sizes in the `ControlButton` demos, listing the default and
  with-background variants each in their own Flex
- Fix `xsmall` icon SVG dimensions (12×12) in the `ControlButton`, `Tag` and
  `UNSTABLE_Picker` demos
- Remove the feature-flag opt-ins from `Tag`, `UNSTABLE_File`,
  `UNSTABLE_FileUpload` and `UNSTABLE_Picker` demos
- Update READMEs, the feature-flags doc and the v5 migration guides

BREAKING CHANGE: `ControlButton` now uses the expanded size scale by default.
The existing `small`/`medium`/`large` sizes are remapped to smaller heights and
`xsmall`/`xlarge` are added. Remove the
`spirit-feature-enable-v5-control-button-expanded-size-scale` CSS class and the
`$enable-v5-control-button-expanded-size-scale` Sass flag from your project; to
keep the previous rendering, shift the size up (`small` → `medium`,
`medium` → `large`, `large` → `xlarge`).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2230 of 3021 branches covered (73.82%)

Branch coverage included in aggregate %.

7072 of 7983 relevant lines covered (88.59%)

198.58 hits per line