valkyrjaio / valkyrja-php / 27736668289

100%

push

github

[View] Add missing tests (#857)

# Description

Brings the framework to 100% phpunit coverage (was 99.94%). Two classes
had uncovered lines: the empty-provider branches in the application
kernel, and the closing brackets of two `??`-fallback default arrays in
the view service provider (which PHP never attributes coverage to).

---

## Types of Changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`src/Valkyrja/View/Orka/Constant/OrkaReplacementCollection.php`** —
new constant class holding the `CORE` and `DEBUG` default Orka
replacement sets
- **`src/Valkyrja/View/Provider/ViewServiceProvider.php`** — reference
`OrkaReplacementCollection::CORE` / `::DEBUG` instead of inline default
arrays, eliminating the uncoverable closing-bracket lines
- **`tests/Tests/Unit/Application/Kernel/ApplicationTest.php`** — added
`testProviderGettersWithNoProviders()` covering the zero-provider `: []`
branches in all four provider getters
- **`tests/Tests/Unit/View/Provider/ServiceProviderTest.php`** — added
`testPublishOrkaRendererWithCustomReplacements()` covering the
env-provided replacements branch

2 of 2 new or added lines in 1 file covered. (100.0%)

12456 of 12456 relevant lines covered (100.0%)

15.57 hits per line