Logflare / logflare / aad1eb921bc98fc7111e622e720d5461966a583a

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(telemetry): emit build commit SHA as OTel resource attribute (#3595)

* feat(telemetry): emit build commit SHA as OTel resource attribute

Surface the build's git commit SHA as a `service.commit` OTel resource
attribute so it lands in BigQuery as `resource._service_commit`. The
`VERSION`-derived `service.version` is bumped only at release time, so it
can't identify which commit the continuously-deployed staging `main`
cluster is running; the SHA gives per-build identity there.

- lib/telemetry.ex: add `commit: System.get_env("LOGFLARE_COMMIT_SHA")` to
  the metrics exporter resource. Unset -> `nil` -> serialized as "" (the
  exporter's is_atom clause), no crash.
- Dockerfile: ARG COMMIT_SHA -> ENV LOGFLARE_COMMIT_SHA in the runner stage.
- docker-ci: pass the already-computed short_sha as the COMMIT_SHA build-arg.

Cloud Build's secret_setup.Dockerfile is FROM the app image and inherits the
ENV; versioned/prod images are retags of the same dev image, so the SHA
propagates to all clusters without Cloud Build changes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(telemetry): omit commit attribute when SHA unset

Build the OTel resource `service` map first and add `commit` only when
`LOGFLARE_COMMIT_SHA` is present, via `maybe_put_commit/2`, instead of
emitting an empty string. An unknown resource attribute should be absent,
not present-but-empty.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(telemetry): cover commit SHA resource attribute, drop empty SHAs

Treat empty/whitespace LOGFLARE_COMMIT_SHA as absent so an unset Docker
build-arg (which expands to "") doesn't emit service.commit: "". Extract
service_resource/1 and add tests covering the set/nil/empty/whitespace cases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(telemetry): assert commit SHA reaches exported OTel resource

Add an end-to-end test that starts OtelMetricExporter with an
export_c... (continued)

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

3 existing lines in 3 files now uncovered.

13184 of 16243 relevant lines covered (81.17%)

5073.34 hits per line