twbs / bootstrap / 27732646677

94%

main: 96%

Build Type

push

github

Committed by web-flow

Commit Message

Dispose existing instance when a component is re-instantiated on an element (#42509)

Re-creating a component on an element that already has one (e.g. `new
Toast(el)` twice) silently overwrote the instances registry, orphaning the
previous instance with its event listeners and timers still attached. Dispose
the existing instance before registering the new one so it is cleaned up
instead of leaking, while keeping `getInstance()` returning the latest instance.

Also guard `_queueCallback` so a transition completion callback is skipped once
the instance has been disposed, preventing the `this._element is null` error
when `dispose()` is called mid-transition.

Closes #37245
Closes #41473

Coverage Stats

1014 of 1130 branches covered (89.73%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

6 existing lines in 2 files now uncovered.

2917 of 3037 relevant lines covered (96.05%)

205.01 hits per line