dcdpr / jp / 27722771184

67%

push

github

refactor(github): Centralize GraphQL error handling in `client.graphql()` (#759)

Previously, each GraphQL mutation caller (`add_review_thread`,
`add_review_thread_reply`) had its own inline check for a top-level
`errors` array in the HTTP 200 response. This was inconsistent: the
check only caught the first error message, used `is_null()` instead of
`is_empty()`, and left other callers (e.g. queries) with no error
handling at all, silently returning partial or empty data.

Now `client.graphql()` handles this once: it deserializes the response
as a raw `Value`, checks for a non-empty `errors` array, and returns an
`Err(Error::GitHub)` that joins all error messages before any
deserialization into `T` occurs. Callers drop their duplicated
error-checking blocks entirely.

As a side effect, the inline comment-node mapping in
`fetch_review_comments` was extracted into a standalone
`parse_review_comment_node` helper, which logs a `tracing::warn!` when a
node has no parseable `fullDatabaseId` instead of silently skipping it.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

86 of 90 new or added lines in 2 files covered. (95.56%)

35632 of 53472 relevant lines covered (66.64%)

401.08 hits per line