27722181023

Committed 17 Jun 2026 09:53PM UTC coverage: 55.052% (-0.07%) from 55.118%

Build # 27722181023

Build Type

Pull #1566

github

Committed by

web-flow

Commit Message

Merge 571306ec2 into 14fd3928a

Pull Request Pull Request #1566: refactor(#1511): fold QtPass::init() fresh-install writes into AppSettings

Coverage Stats

2 of 12 new or added lines in 1 file covered. (16.67%)

3 existing lines in 2 files now uncovered.

3672 of 6670 relevant lines covered (55.05%)

29.41 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

36.68

/src/qtpass.cpp

// SPDX-FileCopyrightText: 2018 Anne Jan Brouwer
// SPDX-License-Identifier: GPL-3.0-or-later
#include "qtpass.h"
#include "mainwindow.h"
#include "qtpasssettings.h"
#include "util.h"
#include <QApplication>
#include <QClipboard>
#include <QDialog>
#include <QLabel>
#include <QPixmap>
#include <QVBoxLayout>

#ifndef Q_OS_WIN
#include <QInputDialog>
#include <QLineEdit>
#include <QMimeData>
#include <utility>
#else
#define WIN32_LEAN_AND_MEAN /*_KILLING_MACHINE*/
#define WIN32_EXTRA_LEAN
#include <windows.h>
#include <winnetwk.h>
#undef DELETE
#include <QMimeData>
#endif

#ifdef QT_DEBUG
#include "debughelper.h"
#endif

/**
 * @brief Constructs a QtPass instance.
 * @param mainWindow The main window reference
 */
QtPass::QtPass(MainWindow *mainWindow) : m_mainWindow(mainWindow) {
  setClipboardTimer();
  clearClipboardTimer.setSingleShot(true);
  connect(&clearClipboardTimer, &QTimer::timeout, this,
          &QtPass::clearClipboard);

  QObject::connect(QApplication::instance(), &QApplication::aboutToQuit, this,
                   &QtPass::clearClipboard);

  setMainWindow();
}

/**
 * @brief QtPass::~QtPass destroy!
 */
QtPass::~QtPass() {
#ifdef Q_OS_WIN
  const AppSettings s = QtPassSettings::load();
  if (s.useWebDav)
    WNetCancelConnection2A(s.passStore.toUtf8().constData(), 0, 1);
#else
  if (fusedav.state() == QProcess::Running) {
    fusedav.terminate();
    fusedav.waitForFinished(2000);
  }
#endif
}

/**
 * @brief QtPass::init make sure we are ready to go as soon as
 * possible
 */
auto QtPass::init() -> bool {
  QString passStore = QtPassSettings::getPassStore(Util::findPasswordStore());
  QtPassSettings::setPassStore(passStore);

  QtPassSettings::initExecutables();

  QString version = QtPassSettings::getVersion();

  // Config updates
  if (version.isEmpty()) {
#ifdef QT_DEBUG
    dbg() << "assuming fresh install";
#endif
    AppSettings s = QtPassSettings::load();
    if (s.autoclearSeconds < 5)
      s.autoclearSeconds = 10;
    if (s.autoclearPanelSeconds < 5)
      s.autoclearPanelSeconds = 10;
    s.usePwgen = !s.pwgenExecutable.isEmpty();
    s.passTemplate = QStringLiteral("login\nurl");
    QtPassSettings::save(s);
  } else {
    AppSettings s = QtPassSettings::load();
    if (s.passTemplate.isEmpty()) {
      s.passTemplate = QStringLiteral("login\nurl");
      QtPassSettings::save(s);
    }
  }

  QtPassSettings::setVersion(VERSION);

  if (!Util::configIsValid(QtPassSettings::load())) {
    m_mainWindow->config();
    if (freshStart && !Util::configIsValid(QtPassSettings::load())) {
      return false;
    }
  }

  // Note: WebDAV mount needs to happen before accessing the store,
  // but ideally should be done after Window is shown to avoid long delay.
  if (QtPassSettings::isUseWebDav()) {
    mountWebDav();
  }

  freshStart = false;
  return true;
}

/**
 * @brief Sets up the main window and connects signal handlers.
 */
void QtPass::setMainWindow() {
  m_mainWindow->restoreWindow();

  fusedav.setParent(m_mainWindow);

  // Signal handlers are connected for both pass implementations
  // Note: When pass binary changes, QtPass restart is required to reconnect
  // This is acceptable as pass binary change is infrequent
  connectPassSignalHandlers(QtPassSettings::getRealPass());
  connectPassSignalHandlers(QtPassSettings::getImitatePass());

  connect(m_mainWindow, &MainWindow::passShowHandlerFinished, this,
          &QtPass::passShowHandlerFinished);

  // only for ipass
  connect(QtPassSettings::getImitatePass(), &ImitatePass::startReencryptPath,
          m_mainWindow, &MainWindow::startReencryptPath);
  connect(QtPassSettings::getImitatePass(), &ImitatePass::endReencryptPath,
          m_mainWindow, &MainWindow::endReencryptPath);

  connect(m_mainWindow, &MainWindow::passGitInitNeeded, []() {
#ifdef QT_DEBUG
    dbg() << "Pass git init called";
#endif
    QtPassSettings::getPass()->GitInit();
  });

  connect(m_mainWindow, &MainWindow::generateGPGKeyPair, m_mainWindow,
          [this](const QString &batch) {
            QtPassSettings::getPass()->GenerateGPGKeys(batch);
            m_mainWindow->showStatusMessage(tr("Generating GPG key pair"),
                                            60000);
          });
}

/**
 * @brief Connects pass signal handlers to QtPass slots.
 * @param pass The pass instance to connect
 */
void QtPass::connectPassSignalHandlers(Pass *pass) {
  connect(pass, &Pass::error, this, &QtPass::processError);
  connect(pass, &Pass::processErrorExit, this, &QtPass::processErrorExit);
  connect(pass, &Pass::critical, m_mainWindow, &MainWindow::critical);
  connect(pass, &Pass::startingExecuteWrapper, m_mainWindow,
          &MainWindow::executeWrapperStarted);
  connect(pass, &Pass::statusMsg, m_mainWindow, &MainWindow::showStatusMessage);
  connect(pass, &Pass::finishedShow, m_mainWindow,
          &MainWindow::passShowHandler);
  connect(pass, &Pass::finishedOtpGenerate, m_mainWindow,
          &MainWindow::passOtpHandler);

  connect(pass, &Pass::finishedGitInit, this, &QtPass::passStoreChanged);
  connect(pass, &Pass::finishedGitPull, this, &QtPass::processFinished);
  connect(pass, &Pass::finishedGitPush, this, &QtPass::processFinished);
  connect(pass, &Pass::finishedInsert, this, &QtPass::finishedInsert);
  connect(pass, &Pass::finishedRemove, this, &QtPass::passStoreChanged);
  connect(pass, &Pass::finishedInit, this, &QtPass::passStoreChanged);
  connect(pass, &Pass::finishedMove, this, &QtPass::passStoreChanged);
  connect(pass, &Pass::finishedCopy, this, &QtPass::passStoreChanged);
  connect(pass, &Pass::finishedGenerateGPGKeys, this,
          &QtPass::onKeyGenerationComplete);
  connect(pass, &Pass::finishedGrep, m_mainWindow, &MainWindow::onGrepFinished);
}

/**
 * @brief QtPass::mountWebDav is some scary voodoo magic
 */
void QtPass::mountWebDav() {
  const AppSettings s = QtPassSettings::load();
#ifdef Q_OS_WIN
  char dst[20] = {0};
  NETRESOURCEA netres;
  memset(&netres, 0, sizeof(netres));
  netres.dwType = RESOURCETYPE_DISK;
  netres.lpLocalName = nullptr;
  // Store QByteArray in variables to ensure lifetime during WNetUseConnectionA
  // call
  QByteArray webDavUrlUtf8 = s.webDavUrl.toUtf8();
  QByteArray webDavPasswordUtf8 = s.webDavPassword.toUtf8();
  QByteArray webDavUserUtf8 = s.webDavUser.toUtf8();
  netres.lpRemoteName = const_cast<char *>(webDavUrlUtf8.constData());
  DWORD size = sizeof(dst);
  DWORD r = WNetUseConnectionA(
      reinterpret_cast<HWND>(m_mainWindow->effectiveWinId()), &netres,
      const_cast<char *>(webDavPasswordUtf8.constData()),
      const_cast<char *>(webDavUserUtf8.constData()),
      CONNECT_TEMPORARY | CONNECT_INTERACTIVE | CONNECT_REDIRECT, dst, &size,
      0);
  if (r == NO_ERROR) {
    QtPassSettings::setPassStore(dst);
  } else {
    char message[256] = {0};
    FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM, 0, r, 0, message,
                   sizeof(message), 0);
    m_mainWindow->flashText(tr("Failed to connect WebDAV:\n") + message +
                                " (0x" + QString::number(r, 16) + ")",
                            true);
  }
#else
  fusedav.start("fusedav", QStringList()
                               << "-o"
                               << "nonempty"
                               << "-u"
                               << "\"" + s.webDavUser + "\"" << s.webDavUrl
                               << "\"" + s.passStore + "\"");
  fusedav.waitForStarted();
  if (fusedav.state() == QProcess::Running) {
    QString pwd = s.webDavPassword;
    bool ok = true;
    if (pwd.isEmpty()) {
      pwd = QInputDialog::getText(m_mainWindow, tr("QtPass WebDAV password"),
                                  tr("Enter password to connect to WebDAV:"),
                                  QLineEdit::Password, "", &ok);
    }
    if (ok && !pwd.isEmpty()) {
      fusedav.write(pwd.toUtf8() + '\n');
      fusedav.closeWriteChannel();
      fusedav.waitForFinished(2000);
    } else {
      fusedav.terminate();
    }
  }
  QString error = fusedav.readAllStandardError();
  qsizetype prompt = error.indexOf("Password:");
  if (prompt >= 0) {
    error.remove(0, prompt + 10);
  }
  if (fusedav.state() != QProcess::Running) {
    error = tr("fusedav exited unexpectedly\n") + error;
  }
  if (error.size() > 0) {
    m_mainWindow->flashText(
        tr("Failed to start fusedav to connect WebDAV:\n") + error, true);
  }
#endif
}

/**
 * @brief QtPass::processError something went wrong
 * @param error
 */
void QtPass::processError(QProcess::ProcessError error) {
  QString errorString;
  switch (error) {
  case QProcess::FailedToStart:
    errorString = tr("QProcess::FailedToStart");
    break;
  case QProcess::Crashed:
    errorString = tr("QProcess::Crashed");
    break;
  case QProcess::Timedout:
    errorString = tr("QProcess::Timedout");
    break;
  case QProcess::ReadError:
    errorString = tr("QProcess::ReadError");
    break;
  case QProcess::WriteError:
    errorString = tr("QProcess::WriteError");
    break;
  case QProcess::UnknownError:
    errorString = tr("QProcess::UnknownError");
    break;
  }
  m_mainWindow->flashText(errorString, true);
  m_mainWindow->setUiElementsEnabled(true);
}

/**
 * @brief Handles process error exit.
 * @param exitCode The exit code
 * @param p_error The error message
 */
void QtPass::processErrorExit(int exitCode, const QString &p_error) {
  if (nullptr != m_mainWindow->getKeyGenDialog()) {
    m_mainWindow->cleanKeygenDialog();
    if (exitCode != 0) {
      m_mainWindow->showStatusMessage(tr("GPG key pair generation failed"),
                                      10000);
    }
  }

  if (!p_error.isEmpty()) {
    QString output;
    QString error = p_error.toHtmlEscaped();
    if (exitCode == 0) {
      //  https://github.com/IJHack/qtpass/issues/111
      output = "<span style=\"color: darkgray;\">" + error + "</span><br />";
    } else {
      output = "<span style=\"color: red;\">" + error + "</span><br />";
    }

    output.replace(Util::protocolRegex(), R"(<a href="\1">\1</a>)");
    output.replace(QStringLiteral("\n"), "<br />");

    m_mainWindow->flashText(output, false, true);
  }

  m_mainWindow->setUiElementsEnabled(true);
}

/**
 * @brief QtPass::processFinished background process has finished
 * @param exitCode
 * @param exitStatus
 * @param output    stdout from a process
 * @param errout    stderr from a process
 */
void QtPass::processFinished(const QString &p_output, const QString &p_errout) {
  showInTextBrowser(p_output);
  //    Sometimes there is error output even with 0 exit code, which is
  //    assumed in this function
  processErrorExit(0, p_errout);

  m_mainWindow->setUiElementsEnabled(true);
}

/**
 * @brief Called when pass store has changed.
 * @param p_out Output from the process
 * @param p_err Error output
 */
void QtPass::passStoreChanged(const QString &p_out, const QString &p_err) {
  processFinished(p_out, p_err);
  doGitPush();
}

/**
 * @brief Called when an insert operation has finished.
 * @param p_output Output from the process
 * @param p_errout Error output
 */
void QtPass::finishedInsert(const QString &p_output, const QString &p_errout) {
  processFinished(p_output, p_errout);
  doGitPush();
  m_mainWindow->on_treeView_clicked(m_mainWindow->getCurrentTreeViewIndex());
}

/**
 * @brief Called when GPG key generation is complete.
 * @param p_output Standard output from the key generation process
 * @param p_errout Standard error output from the key generation process
 */
void QtPass::onKeyGenerationComplete(const QString &p_output,
                                     const QString &p_errout) {
  if (nullptr != m_mainWindow->getKeyGenDialog()) {
#ifdef QT_DEBUG
    qDebug() << "Keygen Done";
#endif

    m_mainWindow->cleanKeygenDialog();
    m_mainWindow->showStatusMessage(tr("GPG key pair generated successfully"),
                                    10000);
  }

  processFinished(p_output, p_errout);
}

/**
 * @brief Called when the password show handler has finished.
 * @param output The password content to display
 */
void QtPass::passShowHandlerFinished(QString output) {
  showInTextBrowser(std::move(output));
}

/**
 * @brief Displays output text in the main window's text browser.
 * @param output The text to display
 * @param prefix Optional prefix to prepend to the output
 * @param postfix Optional postfix to append to the output
 */
void QtPass::showInTextBrowser(QString output, const QString &prefix,
                               const QString &postfix) {
  output = output.toHtmlEscaped();

  output.replace(Util::protocolRegex(), R"(<a href="\1">\1</a>)");
  output.replace(QStringLiteral("\n"), "<br />");
  output = prefix + output + postfix;

  m_mainWindow->flashText(output, false, true);
}

/**
 * @brief Performs automatic git push if enabled in settings.
 */
void QtPass::doGitPush() {
  if (QtPassSettings::isAutoPush()) {
    m_mainWindow->onPush();
  }
}

/**
 * @brief Sets the text to be stored in clipboard and handles clipboard
 * operations.
 * @param password The password or text to store
 * @param p_output Additional output text
 */
void QtPass::setClippedText(const QString &password, const QString &p_output) {
  const AppSettings s = QtPassSettings::load();
  if (s.clipBoardType != Enums::CLIPBOARD_NEVER && !p_output.isEmpty()) {
    clippedText = password;
    if (s.clipBoardType == Enums::CLIPBOARD_ALWAYS) {
      copyTextToClipboard(password);
    }
  }
}
/**
 * @brief Clears the stored clipped text.
 */
void QtPass::clearClippedText() { clippedText = ""; }

/**
 * @brief Sets the clipboard clear timer based on autoclear settings.
 */
void QtPass::setClipboardTimer() {
  clearClipboardTimer.setInterval(MS_PER_SECOND *
                                  QtPassSettings::getAutoclearSeconds());
}

/**
 * @brief MainWindow::clearClipboard remove clipboard contents.
 */
void QtPass::clearClipboard() {
  QClipboard *clipboard = QApplication::clipboard();
  bool cleared = false;
  if (this->clippedText == clipboard->text(QClipboard::Selection)) {
    clipboard->clear(QClipboard::Selection);
    clipboard->setText(QString(""), QClipboard::Selection);
    cleared = true;
  }
  if (this->clippedText == clipboard->text(QClipboard::Clipboard)) {
    clipboard->clear(QClipboard::Clipboard);
    cleared = true;
  }
  if (cleared) {
    m_mainWindow->showStatusMessage(tr("Clipboard cleared"));
  } else {
    m_mainWindow->showStatusMessage(tr("Clipboard not cleared"));
  }

  clippedText.clear();
}

/**
 * @brief Build clipboard MIME data with platform-specific security hints.
 * @param text - Plain text to copy
 * @return QMimeData with text and security hints
 */
auto buildClipboardMimeData(const QString &text) -> QMimeData * {
  auto *mimeData = new QMimeData();
  mimeData->setText(text);
#ifdef Q_OS_LINUX
  mimeData->setData("x-kde-passwordManagerHint", QByteArray("secret"));
#endif
#ifdef Q_OS_MAC
  mimeData->setData("application/x-nspasteboard-concealed-type", QByteArray());
#endif
#ifdef Q_OS_WIN
  mimeData->setData("ExcludeClipboardContentFromMonitorProcessing",
                    dwordBytes(1));
  mimeData->setData("CanIncludeInClipboardHistory", dwordBytes(0));
  mimeData->setData("CanUploadToCloudClipboard", dwordBytes(0));
#endif
  return mimeData;
}

/**
 * @brief MainWindow::copyTextToClipboard copies text to your clipboard
 * @param text
 */
void QtPass::copyTextToClipboard(const QString &text) {
  const AppSettings s = QtPassSettings::load();
  QClipboard *clip = QApplication::clipboard();

  QClipboard::Mode mode = QClipboard::Clipboard;
  if (s.useSelection && clip->supportsSelection()) {
    mode = QClipboard::Selection;
  }

  auto *mimeData = buildClipboardMimeData(text);
  clip->setMimeData(mimeData, mode);

  clippedText = text;
  m_mainWindow->showStatusMessage(tr("Copied to clipboard"));
  if (s.useAutoclear) {
    clearClipboardTimer.start();
  }
}

/**
 * @brief displays the text as qrcode
 * @param text
 */
void QtPass::showTextAsQRCode(const QString &text) {
  const AppSettings s = QtPassSettings::load();
  const QString qrExe = s.qrencodeExecutable.isEmpty()
                            ? QStringLiteral("/usr/bin/qrencode")
                            : s.qrencodeExecutable;
  QProcess qrencode;
  qrencode.start(qrExe, QStringList() << "-o-"
                                      << "-tPNG");
  qrencode.write(text.toUtf8());
  qrencode.closeWriteChannel();
  qrencode.waitForFinished();
  QByteArray output(qrencode.readAllStandardOutput());

  if (qrencode.exitStatus() || qrencode.exitCode()) {
    QString error(qrencode.readAllStandardError());
    m_mainWindow->showStatusMessage(error);
  } else {
    QPixmap image;
    image.loadFromData(output, "PNG");
    QDialog *popup = createQRCodePopup(image);
    popup->exec();
  }
}

/**
 * @brief QtPass::createQRCodePopup creates a popup dialog with the given QR
 * code image. This is extracted for testability. The caller is responsible
 * for showing and managing the popup lifecycle.
 * @param image The QR code pixmap to display
 * @return The created popup dialog
 */
QDialog *QtPass::createQRCodePopup(const QPixmap &image) {
  auto *popup = new QDialog(nullptr, Qt::Popup | Qt::FramelessWindowHint);
  popup->setAttribute(Qt::WA_DeleteOnClose);
  auto *layout = new QVBoxLayout;
  auto *popupLabel = new QLabel();
  layout->addWidget(popupLabel);
  popupLabel->setPixmap(image);
  popupLabel->setScaledContents(true);
  popupLabel->show();
  popup->setLayout(layout);
  popup->move(QCursor::pos());
  return popup;
}

1	// SPDX-FileCopyrightText: 2018 Anne Jan Brouwer
2	// SPDX-License-Identifier: GPL-3.0-or-later
3	#include "qtpass.h"
4	#include "mainwindow.h"
5	#include "qtpasssettings.h"
6	#include "util.h"
7	#include <QApplication>
8	#include <QClipboard>
9	#include <QDialog>
10	#include <QLabel>
11	#include <QPixmap>
12	#include <QVBoxLayout>
13
14	#ifndef Q_OS_WIN
15	#include <QInputDialog>
16	#include <QLineEdit>
17	#include <QMimeData>
18	#include <utility>
19	#else
20	#define WIN32_LEAN_AND_MEAN /_KILLING_MACHINE/
21	#define WIN32_EXTRA_LEAN
22	#include <windows.h>
23	#include <winnetwk.h>
24	#undef DELETE
25	#include <QMimeData>
26	#endif
27
28	#ifdef QT_DEBUG
29	#include "debughelper.h"
30	#endif
31
32	/**
33	* @brief Constructs a QtPass instance.
34	* @param mainWindow The main window reference
35	*/
36	QtPass::QtPass(MainWindow *mainWindow) : m_mainWindow(mainWindow) {	12✔
37	setClipboardTimer();	12✔
38	clearClipboardTimer.setSingleShot(true);	12✔
39	connect(&clearClipboardTimer, &QTimer::timeout, this,	12✔
40	&QtPass::clearClipboard);	12✔
41
42	QObject::connect(QApplication::instance(), &QApplication::aboutToQuit, this,	12✔
43	&QtPass::clearClipboard);	12✔
44
45	setMainWindow();	12✔
46	}	12✔
47
48	/**
49	* @brief QtPass::~QtPass destroy!
50	*/
51	QtPass::~QtPass() {	24✔
52	#ifdef Q_OS_WIN
53	const AppSettings s = QtPassSettings::load();
54	if (s.useWebDav)
55	WNetCancelConnection2A(s.passStore.toUtf8().constData(), 0, 1);
56	#else
57	if (fusedav.state() == QProcess::Running) {	12✔
58	fusedav.terminate();	×
59	fusedav.waitForFinished(2000);	×
60	}
61	#endif
62	}	24✔
63
64	/**
65	* @brief QtPass::init make sure we are ready to go as soon as
66	* possible
67	*/
68	auto QtPass::init() -> bool {	12✔
69	QString passStore = QtPassSettings::getPassStore(Util::findPasswordStore());	12✔
70	QtPassSettings::setPassStore(passStore);	12✔
71
72	QtPassSettings::initExecutables();	12✔
73
74	QString version = QtPassSettings::getVersion();	24✔
75
76	// Config updates
77	if (version.isEmpty()) {	12✔
78	#ifdef QT_DEBUG
79	dbg() << "assuming fresh install";
80	#endif
NEW 81	AppSettings s = QtPassSettings::load();	×
NEW 82	if (s.autoclearSeconds < 5)	×
NEW 83	s.autoclearSeconds = 10;	×
NEW 84	if (s.autoclearPanelSeconds < 5)	×
NEW 85	s.autoclearPanelSeconds = 10;	×
NEW 86	s.usePwgen = !s.pwgenExecutable.isEmpty();	×
NEW 87	s.passTemplate = QStringLiteral("login\nurl");	×
NEW 88	QtPassSettings::save(s);	×
UNCOV 89	} else {	×
90	AppSettings s = QtPassSettings::load();	12✔
91	if (s.passTemplate.isEmpty()) {	12✔
NEW 92	s.passTemplate = QStringLiteral("login\nurl");	×
NEW 93	QtPassSettings::save(s);	×
94	}
95	}	12✔
96
97	QtPassSettings::setVersion(VERSION);	12✔
98
99	if (!Util::configIsValid(QtPassSettings::load())) {	12✔
100	m_mainWindow->config();	×
101	if (freshStart && !Util::configIsValid(QtPassSettings::load())) {	×
102	return false;
103	}
104	}
105
106	// Note: WebDAV mount needs to happen before accessing the store,
107	// but ideally should be done after Window is shown to avoid long delay.
108	if (QtPassSettings::isUseWebDav()) {	12✔
109	mountWebDav();	×
110	}
111
112	freshStart = false;	12✔
113	return true;	12✔
114	}
115
116	/**
117	* @brief Sets up the main window and connects signal handlers.
118	*/
119	void QtPass::setMainWindow() {	12✔
120	m_mainWindow->restoreWindow();	12✔
121
122	fusedav.setParent(m_mainWindow);	12✔
123
124	// Signal handlers are connected for both pass implementations
125	// Note: When pass binary changes, QtPass restart is required to reconnect
126	// This is acceptable as pass binary change is infrequent
127	connectPassSignalHandlers(QtPassSettings::getRealPass());	12✔
128	connectPassSignalHandlers(QtPassSettings::getImitatePass());	12✔
129
130	connect(m_mainWindow, &MainWindow::passShowHandlerFinished, this,	12✔
131	&QtPass::passShowHandlerFinished);	12✔
132
133	// only for ipass
134	connect(QtPassSettings::getImitatePass(), &ImitatePass::startReencryptPath,	12✔
135	m_mainWindow, &MainWindow::startReencryptPath);	12✔
136	connect(QtPassSettings::getImitatePass(), &ImitatePass::endReencryptPath,	12✔
137	m_mainWindow, &MainWindow::endReencryptPath);	12✔
138
139	connect(m_mainWindow, &MainWindow::passGitInitNeeded, []() {	12✔
140	#ifdef QT_DEBUG
141	dbg() << "Pass git init called";
142	#endif
143	QtPassSettings::getPass()->GitInit();	×
144	});	×
145
146	connect(m_mainWindow, &MainWindow::generateGPGKeyPair, m_mainWindow,	12✔
147	[this](const QString &batch) {	12✔
148	QtPassSettings::getPass()->GenerateGPGKeys(batch);	×
149	m_mainWindow->showStatusMessage(tr("Generating GPG key pair"),	×
150	60000);
151	});	×
152	}	12✔
153
154	/**
155	* @brief Connects pass signal handlers to QtPass slots.
156	* @param pass The pass instance to connect
157	*/
158	void QtPass::connectPassSignalHandlers(Pass *pass) {	24✔
159	connect(pass, &Pass::error, this, &QtPass::processError);	24✔
160	connect(pass, &Pass::processErrorExit, this, &QtPass::processErrorExit);	24✔
161	connect(pass, &Pass::critical, m_mainWindow, &MainWindow::critical);	24✔
162	connect(pass, &Pass::startingExecuteWrapper, m_mainWindow,	24✔
163	&MainWindow::executeWrapperStarted);	24✔
164	connect(pass, &Pass::statusMsg, m_mainWindow, &MainWindow::showStatusMessage);	24✔
165	connect(pass, &Pass::finishedShow, m_mainWindow,	24✔
166	&MainWindow::passShowHandler);	24✔
167	connect(pass, &Pass::finishedOtpGenerate, m_mainWindow,	24✔
168	&MainWindow::passOtpHandler);	24✔
169
170	connect(pass, &Pass::finishedGitInit, this, &QtPass::passStoreChanged);	24✔
171	connect(pass, &Pass::finishedGitPull, this, &QtPass::processFinished);	24✔
172	connect(pass, &Pass::finishedGitPush, this, &QtPass::processFinished);	24✔
173	connect(pass, &Pass::finishedInsert, this, &QtPass::finishedInsert);	24✔
174	connect(pass, &Pass::finishedRemove, this, &QtPass::passStoreChanged);	24✔
175	connect(pass, &Pass::finishedInit, this, &QtPass::passStoreChanged);	24✔
176	connect(pass, &Pass::finishedMove, this, &QtPass::passStoreChanged);	24✔
177	connect(pass, &Pass::finishedCopy, this, &QtPass::passStoreChanged);	24✔
178	connect(pass, &Pass::finishedGenerateGPGKeys, this,	24✔
179	&QtPass::onKeyGenerationComplete);	24✔
180	connect(pass, &Pass::finishedGrep, m_mainWindow, &MainWindow::onGrepFinished);	24✔
181	}	24✔
182
183	/**
184	* @brief QtPass::mountWebDav is some scary voodoo magic
185	*/
186	void QtPass::mountWebDav() {	×
187	const AppSettings s = QtPassSettings::load();	×
188	#ifdef Q_OS_WIN
189	char dst[20] = {0};
190	NETRESOURCEA netres;
191	memset(&netres, 0, sizeof(netres));
192	netres.dwType = RESOURCETYPE_DISK;
193	netres.lpLocalName = nullptr;
194	// Store QByteArray in variables to ensure lifetime during WNetUseConnectionA
195	// call
196	QByteArray webDavUrlUtf8 = s.webDavUrl.toUtf8();
197	QByteArray webDavPasswordUtf8 = s.webDavPassword.toUtf8();
198	QByteArray webDavUserUtf8 = s.webDavUser.toUtf8();
199	netres.lpRemoteName = const_cast<char *>(webDavUrlUtf8.constData());
200	DWORD size = sizeof(dst);
201	DWORD r = WNetUseConnectionA(
202	reinterpret_cast<HWND>(m_mainWindow->effectiveWinId()), &netres,
203	const_cast<char *>(webDavPasswordUtf8.constData()),
204	const_cast<char *>(webDavUserUtf8.constData()),
205	CONNECT_TEMPORARY \| CONNECT_INTERACTIVE \| CONNECT_REDIRECT, dst, &size,
206	0);
207	if (r == NO_ERROR) {
208	QtPassSettings::setPassStore(dst);
209	} else {
210	char message[256] = {0};
211	FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM, 0, r, 0, message,
212	sizeof(message), 0);
213	m_mainWindow->flashText(tr("Failed to connect WebDAV:\n") + message +
214	" (0x" + QString::number(r, 16) + ")",
215	true);
216	}
217	#else
218	fusedav.start("fusedav", QStringList()	×
219	<< "-o"	×
220	<< "nonempty"	×
221	<< "-u"	×
222	<< "\"" + s.webDavUser + "\"" << s.webDavUrl	×
223	<< "\"" + s.passStore + "\"");	×
224	fusedav.waitForStarted();	×
225	if (fusedav.state() == QProcess::Running) {	×
226	QString pwd = s.webDavPassword;
227	bool ok = true;	×
228	if (pwd.isEmpty()) {	×
229	pwd = QInputDialog::getText(m_mainWindow, tr("QtPass WebDAV password"),	×
230	tr("Enter password to connect to WebDAV:"),	×
231	QLineEdit::Password, "", &ok);
232	}
233	if (ok && !pwd.isEmpty()) {	×
234	fusedav.write(pwd.toUtf8() + '\n');	×
235	fusedav.closeWriteChannel();	×
236	fusedav.waitForFinished(2000);	×
237	} else {
238	fusedav.terminate();	×
239	}
240	}
241	QString error = fusedav.readAllStandardError();	×
242	qsizetype prompt = error.indexOf("Password:");	×
243	if (prompt >= 0) {	×
244	error.remove(0, prompt + 10);	×
245	}
246	if (fusedav.state() != QProcess::Running) {	×
247	error = tr("fusedav exited unexpectedly\n") + error;	×
248	}
249	if (error.size() > 0) {	×
250	m_mainWindow->flashText(	×
251	tr("Failed to start fusedav to connect WebDAV:\n") + error, true);	×
252	}
253	#endif
254	}	×
255
256	/**
257	* @brief QtPass::processError something went wrong
258	* @param error
259	*/
260	void QtPass::processError(QProcess::ProcessError error) {	×
261	QString errorString;	×
262	switch (error) {	×
263	case QProcess::FailedToStart:	×
264	errorString = tr("QProcess::FailedToStart");	×
265	break;	×
266	case QProcess::Crashed:	×
267	errorString = tr("QProcess::Crashed");	×
268	break;	×
269	case QProcess::Timedout:	×
270	errorString = tr("QProcess::Timedout");	×
271	break;	×
272	case QProcess::ReadError:	×
273	errorString = tr("QProcess::ReadError");	×
274	break;	×
275	case QProcess::WriteError:	×
276	errorString = tr("QProcess::WriteError");	×
277	break;	×
278	case QProcess::UnknownError:	×
279	errorString = tr("QProcess::UnknownError");	×
280	break;	×
281	}
282	m_mainWindow->flashText(errorString, true);	×
283	m_mainWindow->setUiElementsEnabled(true);	×
284	}	×
285
286	/**
287	* @brief Handles process error exit.
288	* @param exitCode The exit code
289	* @param p_error The error message
290	*/
291	void QtPass::processErrorExit(int exitCode, const QString &p_error) {	×
292	if (nullptr != m_mainWindow->getKeyGenDialog()) {	×
293	m_mainWindow->cleanKeygenDialog();	×
294	if (exitCode != 0) {	×
295	m_mainWindow->showStatusMessage(tr("GPG key pair generation failed"),	×
296	10000);
297	}
298	}
299
300	if (!p_error.isEmpty()) {	×
301	QString output;	×
302	QString error = p_error.toHtmlEscaped();	×
303	if (exitCode == 0) {	×
304	// https://github.com/IJHack/qtpass/issues/111
305	output = "<span style=\"color: darkgray;\">" + error + "</span><br />";	×
306	} else {
307	output = "<span style=\"color: red;\">" + error + "</span><br />";	×
308	}
309
310	output.replace(Util::protocolRegex(), R"(<a href="\1">\1</a>)");	×
311	output.replace(QStringLiteral("\n"), "<br />");	×
312
313	m_mainWindow->flashText(output, false, true);	×
314	}
315
316	m_mainWindow->setUiElementsEnabled(true);	×
317	}	×
318
319	/**
320	* @brief QtPass::processFinished background process has finished
321	* @param exitCode
322	* @param exitStatus
323	* @param output stdout from a process
324	* @param errout stderr from a process
325	*/
326	void QtPass::processFinished(const QString &p_output, const QString &p_errout) {	×
327	showInTextBrowser(p_output);	×
328	// Sometimes there is error output even with 0 exit code, which is
329	// assumed in this function
330	processErrorExit(0, p_errout);	×
331
332	m_mainWindow->setUiElementsEnabled(true);	×
333	}	×
334
335	/**
336	* @brief Called when pass store has changed.
337	* @param p_out Output from the process
338	* @param p_err Error output
339	*/
340	void QtPass::passStoreChanged(const QString &p_out, const QString &p_err) {	×
341	processFinished(p_out, p_err);	×
342	doGitPush();	×
343	}	×
344
345	/**
346	* @brief Called when an insert operation has finished.
347	* @param p_output Output from the process
348	* @param p_errout Error output
349	*/
350	void QtPass::finishedInsert(const QString &p_output, const QString &p_errout) {	×
351	processFinished(p_output, p_errout);	×
352	doGitPush();	×
353	m_mainWindow->on_treeView_clicked(m_mainWindow->getCurrentTreeViewIndex());	×
354	}	×
355
356	/**
357	* @brief Called when GPG key generation is complete.
358	* @param p_output Standard output from the key generation process
359	* @param p_errout Standard error output from the key generation process
360	*/
361	void QtPass::onKeyGenerationComplete(const QString &p_output,	×
362	const QString &p_errout) {
363	if (nullptr != m_mainWindow->getKeyGenDialog()) {	×
364	#ifdef QT_DEBUG
365	qDebug() << "Keygen Done";
366	#endif
367
368	m_mainWindow->cleanKeygenDialog();	×
369	m_mainWindow->showStatusMessage(tr("GPG key pair generated successfully"),	×
370	10000);
371	}
372
373	processFinished(p_output, p_errout);	×
374	}	×
375
376	/**
377	* @brief Called when the password show handler has finished.
378	* @param output The password content to display
379	*/
380	void QtPass::passShowHandlerFinished(QString output) {	×
381	showInTextBrowser(std::move(output));	×
382	}	×
383
384	/**
385	* @brief Displays output text in the main window's text browser.
386	* @param output The text to display
387	* @param prefix Optional prefix to prepend to the output
388	* @param postfix Optional postfix to append to the output
389	*/
390	void QtPass::showInTextBrowser(QString output, const QString &prefix,	×
391	const QString &postfix) {
392	output = output.toHtmlEscaped();	×
393
394	output.replace(Util::protocolRegex(), R"(<a href="\1">\1</a>)");	×
395	output.replace(QStringLiteral("\n"), "<br />");	×
396	output = prefix + output + postfix;	×
397
398	m_mainWindow->flashText(output, false, true);	×
399	}	×
400
401	/**
402	* @brief Performs automatic git push if enabled in settings.
403	*/
404	void QtPass::doGitPush() {	×
405	if (QtPassSettings::isAutoPush()) {	×
406	m_mainWindow->onPush();	×
407	}
408	}	×
409
410	/**
411	* @brief Sets the text to be stored in clipboard and handles clipboard
412	* operations.
413	* @param password The password or text to store
414	* @param p_output Additional output text
415	*/
416	void QtPass::setClippedText(const QString &password, const QString &p_output) {	×
417	const AppSettings s = QtPassSettings::load();	×
418	if (s.clipBoardType != Enums::CLIPBOARD_NEVER && !p_output.isEmpty()) {	×
419	clippedText = password;	×
420	if (s.clipBoardType == Enums::CLIPBOARD_ALWAYS) {	×
421	copyTextToClipboard(password);	×
422	}
423	}
424	}	×
425	/**
426	* @brief Clears the stored clipped text.
427	*/
428	void QtPass::clearClippedText() { clippedText = ""; }	×
429
430	/**
431	* @brief Sets the clipboard clear timer based on autoclear settings.
432	*/
433	void QtPass::setClipboardTimer() {	12✔
434	clearClipboardTimer.setInterval(MS_PER_SECOND *	24✔
435	QtPassSettings::getAutoclearSeconds());	24✔
436	}	12✔
437
438	/**
439	* @brief MainWindow::clearClipboard remove clipboard contents.
440	*/
441	void QtPass::clearClipboard() {	1✔
442	QClipboard *clipboard = QApplication::clipboard();	1✔
443	bool cleared = false;
444	if (this->clippedText == clipboard->text(QClipboard::Selection)) {	1✔
445	clipboard->clear(QClipboard::Selection);	1✔
446	clipboard->setText(QString(""), QClipboard::Selection);	2✔
447	cleared = true;
448	}
449	if (this->clippedText == clipboard->text(QClipboard::Clipboard)) {	2✔
450	clipboard->clear(QClipboard::Clipboard);	1✔
451	cleared = true;
452	}
453	if (cleared) {	×
454	m_mainWindow->showStatusMessage(tr("Clipboard cleared"));	2✔
455	} else {
456	m_mainWindow->showStatusMessage(tr("Clipboard not cleared"));	×
457	}
458
459	clippedText.clear();	1✔
460	}	1✔
461
462	/**
463	* @brief Build clipboard MIME data with platform-specific security hints.
464	* @param text - Plain text to copy
465	* @return QMimeData with text and security hints
466	*/
467	auto buildClipboardMimeData(const QString &text) -> QMimeData * {	1✔
468	auto *mimeData = new QMimeData();	1✔
469	mimeData->setText(text);	1✔
470	#ifdef Q_OS_LINUX
471	mimeData->setData("x-kde-passwordManagerHint", QByteArray("secret"));	2✔
472	#endif
473	#ifdef Q_OS_MAC
474	mimeData->setData("application/x-nspasteboard-concealed-type", QByteArray());
475	#endif
476	#ifdef Q_OS_WIN
477	mimeData->setData("ExcludeClipboardContentFromMonitorProcessing",
478	dwordBytes(1));
479	mimeData->setData("CanIncludeInClipboardHistory", dwordBytes(0));
480	mimeData->setData("CanUploadToCloudClipboard", dwordBytes(0));
481	#endif
482	return mimeData;	1✔
483	}
484
485	/**
486	* @brief MainWindow::copyTextToClipboard copies text to your clipboard
487	* @param text
488	*/
489	void QtPass::copyTextToClipboard(const QString &text) {	×
490	const AppSettings s = QtPassSettings::load();	×
491	QClipboard *clip = QApplication::clipboard();	×
492
493	QClipboard::Mode mode = QClipboard::Clipboard;
494	if (s.useSelection && clip->supportsSelection()) {	×
495	mode = QClipboard::Selection;
496	}
497
498	auto *mimeData = buildClipboardMimeData(text);	×
499	clip->setMimeData(mimeData, mode);	×
500
501	clippedText = text;	×
502	m_mainWindow->showStatusMessage(tr("Copied to clipboard"));	×
503	if (s.useAutoclear) {	×
504	clearClipboardTimer.start();	×
505	}
506	}	×
507
508	/**
509	* @brief displays the text as qrcode
510	* @param text
511	*/
512	void QtPass::showTextAsQRCode(const QString &text) {	×
513	const AppSettings s = QtPassSettings::load();	×
514	const QString qrExe = s.qrencodeExecutable.isEmpty()
515	? QStringLiteral("/usr/bin/qrencode")	×
516	: s.qrencodeExecutable;
517	QProcess qrencode;	×
518	qrencode.start(qrExe, QStringList() << "-o-"	×
519	<< "-tPNG");	×
520	qrencode.write(text.toUtf8());	×
521	qrencode.closeWriteChannel();	×
522	qrencode.waitForFinished();	×
523	QByteArray output(qrencode.readAllStandardOutput());	×
524
525	if (qrencode.exitStatus() \|\| qrencode.exitCode()) {	×
526	QString error(qrencode.readAllStandardError());	×
527	m_mainWindow->showStatusMessage(error);	×
528	} else {
529	QPixmap image;	×
530	image.loadFromData(output, "PNG");	×
531	QDialog *popup = createQRCodePopup(image);	×
532	popup->exec();	×
533	}	×
534	}	×
535
536	/**
537	* @brief QtPass::createQRCodePopup creates a popup dialog with the given QR
538	* code image. This is extracted for testability. The caller is responsible
539	* for showing and managing the popup lifecycle.
540	* @param image The QR code pixmap to display
541	* @return The created popup dialog
542	*/
543	QDialog *QtPass::createQRCodePopup(const QPixmap &image) {	1✔
544	auto *popup = new QDialog(nullptr, Qt::Popup \| Qt::FramelessWindowHint);	1✔
545	popup->setAttribute(Qt::WA_DeleteOnClose);	1✔
546	auto *layout = new QVBoxLayout;	1✔
547	auto *popupLabel = new QLabel();	1✔
548	layout->addWidget(popupLabel);	1✔
549	popupLabel->setPixmap(image);	1✔
550	popupLabel->setScaledContents(true);	1✔
551	popupLabel->show();	1✔
552	popup->setLayout(layout);	1✔
553	popup->move(QCursor::pos());	1✔
554	return popup;	1✔
555	}

IJHack / QtPass / 27722181023

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous