carapace-sh / carapace-jjlex / 27714785199

66%

master: 66%

Build Type

Pull #26

github

Committed by rsteube

Commit Message

Replace JSON hack with proper bookmark classification for revset completion

The previous implementation used encoding/json marshal/unmarshal to
filter ActionRevs results into simple vs quoted bookmarks, which was
brittle and unnecessary. Fix at the source instead:

- parseBookmarkValues now strips jj's display quotes from bookmark
  names (e.g. "parents(" → parents() and splits into simple/non-simple
  lists using IsSimpleIdentifier
- Add ActionLocalQuotedBookmarks, ActionRemoteQuotedBookmarks,
  ActionQuotedRevs for string completion contexts
- InStringArg and ExpectedStringClose handlers use ActionQuotedRevs
  instead of ActionRevs (only non-simple identifiers need quoting)
- Export IsSimpleIdentifier and QuoteIfNeeded from revset package
- Rewrite IsSimpleIdentifier to match full jj grammar with connectors
- Remove actionRevsQuoted, actionRevsQuotedRaw, actionRevsSimple,
  actionRevsetArgSimple and encoding/json import

Assisted-by: Crush:glm-5.1

Pull Request Pull Request #26: fix partial string completion

Coverage Stats

79 of 153 new or added lines in 5 files covered. (51.63%)

1 existing line in 1 file now uncovered.

4725 of 7122 relevant lines covered (66.34%)

0.75 hits per line